adar (Adar Tulloch)
Disabled

Projects

User does not belong to any projects.

User Details

User Since: Nov 11 2022, 9:07 AM (104 w, 6 d)
Roles: Disabled

Recent Activity
View All

Jan 11 2023

• adar closed D6188: [image-picker] configure privacy permissions on ios.

Jan 11 2023, 12:25 PM

• adar committed rCOMM59cd000299ba: [image-picker] configure privacy permissions on ios (authored by • adar).

[image-picker] configure privacy permissions on ios

Jan 11 2023, 12:25 PM

• adar closed D6187: [image-picker] install expo package.

Jan 11 2023, 12:25 PM

• adar committed rCOMM3e7b49ecbe4f: [image-picker] install expo package (authored by • adar).

[image-picker] install expo package

Jan 11 2023, 12:25 PM

• adar published D6188: [image-picker] configure privacy permissions on ios for review.

Jan 11 2023, 11:41 AM

• adar abandoned D6147: [image-picker] configure iOS microphone privacy permission.

Jan 11 2023, 11:41 AM

• adar requested review of D6147: [image-picker] configure iOS microphone privacy permission.

Jan 11 2023, 11:40 AM

Jan 6 2023

• adar published D6187: [image-picker] install expo package for review.

Jan 6 2023, 7:39 AM

Jan 5 2023

• adar closed D6185: Revert "[image-picker] install expo-image-picker lib".

Jan 5 2023, 2:07 PM

• adar added a reverting change for D6145: [image-picker] install expo-image-picker lib: rCOMM7d190959d111: Revert "[image-picker] install expo-image-picker lib".

Jan 5 2023, 2:07 PM

• adar added a reverting change for rCOMM6a227d2721ed: [image-picker] install expo-image-picker lib: rCOMM7d190959d111: Revert "[image-picker] install expo-image-picker lib".

Jan 5 2023, 2:07 PM

• adar committed rCOMM7d190959d111: Revert "[image-picker] install expo-image-picker lib" (authored by • adar).

Revert "[image-picker] install expo-image-picker lib"

Jan 5 2023, 2:07 PM

• adar added a reverting change for D6145: [image-picker] install expo-image-picker lib: D6185: Revert "[image-picker] install expo-image-picker lib".

Jan 5 2023, 1:56 PM

• adar added a reverting change for rCOMM6a227d2721ed: [image-picker] install expo-image-picker lib: D6185: Revert "[image-picker] install expo-image-picker lib".

Jan 5 2023, 1:56 PM

• adar updated the diff for D6147: [image-picker] configure iOS microphone privacy permission.

do both plists

Jan 5 2023, 12:37 PM

• adar closed D6145: [image-picker] install expo-image-picker lib.

Jan 5 2023, 12:02 PM

• adar committed rCOMM6a227d2721ed: [image-picker] install expo-image-picker lib (authored by • adar).

[image-picker] install expo-image-picker lib

Jan 5 2023, 12:02 PM

Jan 4 2023

• adar added inline comments to D6145: [image-picker] install expo-image-picker lib.

Jan 4 2023, 4:26 PM

• adar updated the diff for D6145: [image-picker] install expo-image-picker lib.

manually updated package.json and ran yarn cleaninstall in root

Jan 4 2023, 4:25 PM

Jan 3 2023

• adar updated the test plan for D6147: [image-picker] configure iOS microphone privacy permission.

Jan 3 2023, 7:40 PM

• adar updated the diff for D6147: [image-picker] configure iOS microphone privacy permission.

added release plist as well

Jan 3 2023, 7:33 PM

• adar added a reviewer for D6145: [image-picker] install expo-image-picker lib: ashoat.

Jan 3 2023, 11:53 AM

• adar updated the summary of D6147: [image-picker] configure iOS microphone privacy permission.

Jan 3 2023, 10:18 AM

• adar published D6147: [image-picker] configure iOS microphone privacy permission for review.

Jan 3 2023, 10:18 AM

• adar published D6145: [image-picker] install expo-image-picker lib for review.

Jan 3 2023, 10:18 AM

Dec 7 2022

• adar closed D5833: [web] Add unread indicator to sidebar modals.

Dec 7 2022, 12:21 PM

• adar committed rCOMM3482588d8bf6: [web] Add unread indicator to sidebar modals (authored by • adar).

[web] Add unread indicator to sidebar modals

Dec 7 2022, 12:21 PM

• adar updated the test plan for D5833: [web] Add unread indicator to sidebar modals.

Dec 7 2022, 11:36 AM

• adar updated the diff for D5833: [web] Add unread indicator to sidebar modals.

make thread name appear bold as well

Dec 7 2022, 11:34 AM

• adar closed D5810: [web] Add unread indicator within subchannel model.

Dec 7 2022, 6:57 AM

• adar committed rCOMM453b74bf6d6b: [web] Add unread indicator within subchannel model (authored by • adar).

[web] Add unread indicator within subchannel model

Dec 7 2022, 6:57 AM

Dec 6 2022

• adar added a comment to D5833: [web] Add unread indicator to sidebar modals.

In D5833#174057, @atul wrote:

Should we also be styling the "new thread" in the example screenshot you posted?

Dec 6 2022, 11:02 AM

• adar published D5833: [web] Add unread indicator to sidebar modals for review.

Dec 6 2022, 8:10 AM

Dec 5 2022

• adar published D5810: [web] Add unread indicator within subchannel model for review.

Dec 5 2022, 2:43 PM

• adar closed D5788: [web] Disable 'change password' button until text inputs are not empty.

Dec 5 2022, 10:32 AM

• adar committed rCOMM333cd87889de: [web] Disable 'change password' button until text inputs are not empty (authored by • adar).

[web] Disable 'change password' button until text inputs are not empty

Dec 5 2022, 10:32 AM

• adar closed D5777: [web] 1/N Disable 'Delete' button on delete account modal when password input is empty.

Dec 5 2022, 10:32 AM

• adar closed D5778: [native] 2/N Disable 'Delete' button on delete acconut modal when password input is empty.

Dec 5 2022, 10:32 AM

• adar committed rCOMM3ccdba9199ff: [web] 1/N Disable 'Delete' button on delete account modal when password input… (authored by • adar).

[web] 1/N Disable 'Delete' button on delete account modal when password input…

Dec 5 2022, 10:32 AM

• adar committed rCOMMae55af8a7cce: [native] 2/N Disable 'Delete' button on delete acconut modal when password… (authored by • adar).

[native] 2/N Disable 'Delete' button on delete acconut modal when password…

Dec 5 2022, 10:32 AM

Dec 1 2022

• adar published D5788: [web] Disable 'change password' button until text inputs are not empty for review.

Dec 1 2022, 7:44 AM

Nov 30 2022

• adar updated the summary of D5778: [native] 2/N Disable 'Delete' button on delete acconut modal when password input is empty.

Nov 30 2022, 7:18 PM

• adar updated the summary of D5778: [native] 2/N Disable 'Delete' button on delete acconut modal when password input is empty.

Nov 30 2022, 7:18 PM

• adar added a comment to D5778: [native] 2/N Disable 'Delete' button on delete acconut modal when password input is empty.

In D5778#172487, @ashoat wrote:

You need a test plan and you need reviewers. Please don't submit diffs in this state

Nov 30 2022, 5:27 PM

• adar added a reviewer for D5777: [web] 1/N Disable 'Delete' button on delete account modal when password input is empty: atul.

Nov 30 2022, 5:24 PM

• adar requested review of D5778: [native] 2/N Disable 'Delete' button on delete acconut modal when password input is empty.

Nov 30 2022, 12:50 PM

• adar requested review of D5777: [web] 1/N Disable 'Delete' button on delete account modal when password input is empty.

Nov 30 2022, 12:04 PM

• adar closed D5761: [web] Remove friend request suggestion in sidebar chats.

Nov 30 2022, 11:16 AM

• adar committed rCOMMe1a38bfdcc54: [web] Remove friend request suggestion in sidebar chats (authored by • adar).

[web] Remove friend request suggestion in sidebar chats

Nov 30 2022, 11:16 AM

• adar updated the test plan for D5761: [web] Remove friend request suggestion in sidebar chats.

Nov 30 2022, 11:05 AM

• adar added a comment to D5761: [web] Remove friend request suggestion in sidebar chats.

In D5761#172111, @tomek wrote:

Regarding the test plan, you also have to check if the prompt is still displayed in PERSONAL threads.

Nov 30 2022, 11:03 AM

• adar updated the test plan for D5761: [web] Remove friend request suggestion in sidebar chats.

Nov 30 2022, 11:01 AM

Nov 29 2022

• adar requested review of D5761: [web] Remove friend request suggestion in sidebar chats.

Nov 29 2022, 2:54 PM

Nov 28 2022

• adar closed D5743: [docs] Remove 'you can' instance from non-optional steps.

Nov 28 2022, 8:29 PM

• adar committed rCOMMb3b267eab769: [docs] Remove 'you can' instance from non-optional steps (authored by • adar).

[docs] Remove 'you can' instance from non-optional steps

Nov 28 2022, 8:29 PM

• adar added a comment to D5743: [docs] Remove 'you can' instance from non-optional steps.

In D5743#171198, @atul wrote:

I think the intent was to avoid an imperative or ordering tone.

I believe the intent here was to remove "you can" because it could give the impression that a step is optional.

(@adar might be helpful to include a Linear link or something in the future to provide that context)

Nov 28 2022, 11:23 AM

• adar updated the summary of D5743: [docs] Remove 'you can' instance from non-optional steps.

Nov 28 2022, 11:14 AM

• adar requested review of D5743: [docs] Remove 'you can' instance from non-optional steps.

Nov 28 2022, 10:46 AM

Nov 21 2022

• adar closed D5697: [web] Refactor - remove instances of useMemo + classNames combo.

Nov 21 2022, 10:22 AM

• adar committed rCOMM8fb121d970f4: [web] Refactor - remove instances of useMemo + classNames combo (authored by • adar).

[web] Refactor - remove instances of useMemo + classNames combo

Nov 21 2022, 10:22 AM

• adar removed a reviewer for D5697: [web] Refactor - remove instances of useMemo + classNames combo: ashoat.

Nov 21 2022, 6:30 AM

• adar updated subscribers of D5697: [web] Refactor - remove instances of useMemo + classNames combo.

In D5697#169354, @ashoat wrote:

Please don't add me to reviews except in these cases

sorry, noted! :)

Nov 21 2022, 6:29 AM

• adar updated the diff for D5697: [web] Refactor - remove instances of useMemo + classNames combo.

remove change from setting up dev environment

Nov 21 2022, 5:59 AM

• adar requested review of D5697: [web] Refactor - remove instances of useMemo + classNames combo.

Nov 21 2022, 5:57 AM

Nov 11 2022

ashoat renamed • adar from uhdar to adar.

Nov 11 2022, 10:57 AM