Paths

Table of Contentst

[lib] Replace `LegacyThreadInfo` with `ThreadInfo` where simple
ClosedPublic
Actions

Authored by atul on Dec 1 2023, 3:02 AM.

Details

Reviewers

ashoat
ginsu
tomek
rohan

Commits

rCOMMe20649909cae: [lib] Replace `LegacyThreadInfo` with `ThreadInfo` where simple

Summary

Went through and swapped LegacyThreadInfo with ThreadInfo where it was simple. Will need to go through web and native and update some of the "leaf components" to make further updates.

Depends on D10125

Test Plan

CI/flow/etc

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Dec 1 2023, 3:02 AM

We're now at 236 instances of LegacyThreadInfo down from 700+

Harbormaster completed remote builds in B24672: Diff 34086.Dec 1 2023, 3:22 AM

atul requested review of this revision.Dec 1 2023, 3:22 AM

atul added a child revision: D10127: [native] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.Dec 1 2023, 3:45 AM

ashoat accepted this revision.Dec 1 2023, 3:59 AM

This revision is now accepted and ready to land.Dec 1 2023, 3:59 AM

atul mentioned this in D10128: [web] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.Dec 1 2023, 4:13 AM

Closed by commit rCOMMe20649909cae: [lib] Replace `LegacyThreadInfo` with `ThreadInfo` where simple. · Explain WhyDec 1 2023, 8:44 PM

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMMe20649909cae: [lib] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.

atul mentioned this in rCOMM1fe88fb3a208: [web] Replace `LegacyThreadInfo` with `ThreadInfo` where simple.

Revision Contents
Changeset List

Path

Size

lib/

selectors/

thread-selectors.js

39 lines

shared/

thread-utils.js

2 lines

types/

messages/

create-sidebar.js

4 lines

create-subthread.js

4 lines

create-thread.js

4 lines

utils/

entity-helpers.js

2 lines

Diff 34086

View Options

lib/selectors/thread-selectors.js

View Options

lib/shared/thread-utils.js

View Options

lib/types/messages/create-sidebar.js

View Options

lib/types/messages/create-subthread.js

View Options

lib/types/messages/create-thread.js

View Options

lib/utils/entity-helpers.js

[lib] Replace `LegacyThreadInfo` with `ThreadInfo` where simpleClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 34086

lib/selectors/thread-selectors.js

lib/shared/thread-utils.js

lib/types/messages/create-sidebar.js

lib/types/messages/create-subthread.js

lib/types/messages/create-thread.js

lib/utils/entity-helpers.js

[lib] Replace `LegacyThreadInfo` with `ThreadInfo` where simple
ClosedPublic
Actions

Revision Contents
Changeset List