Page MenuHomePhabricator
Differential D10145

[web] introduce light mode to create/edit role modal
ClosedPublic
Actions

Authored by ginsu on Dec 1 2023, 2:14 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 4 2024, 7:01 AM
Unknown Object (File)
Feb 21 2024, 2:18 PM
Unknown Object (File)
Feb 21 2024, 8:37 AM
Unknown Object (File)
Feb 21 2024, 7:46 AM
Unknown Object (File)
Feb 21 2024, 7:08 AM
Unknown Object (File)
Feb 21 2024, 12:13 AM
Unknown Object (File)
Feb 20 2024, 10:44 PM
Unknown Object (File)
Jan 28 2024, 12:11 AM
View All 20 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
rohan
Commits
rCOMMc0c4171aedb5: [web] introduce light mode to create/edit role modal
Summary

This diff introduces the new color design system/light mode to the create/edit role modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-4840/createedit-role-modal

Depends on D10144

Test Plan

Please see screenshots below

dark:

Screenshot 2023-12-01 at 5.17.24 PM.png (1×3 px, 788 KB)

light:

Screenshot 2023-12-01 at 5.17.54 PM.png (1×3 px, 788 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 1 2023, 2:14 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 1 2023, 2:14 PM
ginsu edited the summary of this revision. (Show Details)Dec 1 2023, 2:19 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a parent revision: D10144: [web] introduce light mode to community creation modal.
ginsu attached a referenced file: F906437: Screenshot 2023-12-01 at 5.17.24 PM.png. (Show Details)
ginsu attached a referenced file: F906438: Screenshot 2023-12-01 at 5.17.54 PM.png. (Show Details)
ginsu edited the summary of this revision. (Show Details)Dec 1 2023, 2:22 PM
Harbormaster completed remote builds in B24713: Diff 34161.Dec 1 2023, 2:42 PM
ginsu requested review of this revision.Dec 1 2023, 2:42 PM
ginsu added a child revision: D10146: [web] introduce light to delete role modal.Dec 1 2023, 2:49 PM
rohan requested changes to this revision.Dec 4 2023, 5:50 AM

Requesting changes just for a question. The screenshots look fine, but for consistency do we need to add a --link-background-primary-disabled to the light mode variables?

This revision now requires changes to proceed.Dec 4 2023, 5:50 AM
ginsu updated this revision to Diff 34264.EditedDec 4 2023, 11:52 PM

address comments (thanks for catching that @rohan!)

Harbormaster completed remote builds in B24793: Diff 34264.Dec 5 2023, 12:48 AM
rohan accepted this revision.Dec 5 2023, 7:43 AM
This revision is now accepted and ready to land.Dec 5 2023, 7:43 AM
ginsu updated this revision to Diff 34348.Dec 6 2023, 10:49 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 6 2023, 10:52 AM
Closed by commit rCOMMc0c4171aedb5: [web] introduce light mode to create/edit role modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMc0c4171aedb5: [web] introduce light mode to create/edit role modal.
Harbormaster completed remote builds in B24830: Diff 34348.Dec 6 2023, 11:34 AM

Revision Contents
Changeset List

PathSize
web/
roles/
13 lines
3 lines

Diff 34352

View Options

web/roles/create-roles-modal.css

Loading...
View Options

web/theme.css

Loading...