Page MenuHomePhabricator
Differential D10146

[web] introduce light to delete role modal
ClosedPublic
Actions

Authored by ginsu on Dec 1 2023, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 8 2024, 5:32 AM
Unknown Object (File)
Feb 20 2024, 8:28 PM
Unknown Object (File)
Feb 20 2024, 5:01 PM
Unknown Object (File)
Feb 20 2024, 4:31 PM
Unknown Object (File)
Feb 20 2024, 3:58 PM
Unknown Object (File)
Feb 20 2024, 9:13 AM
Unknown Object (File)
Feb 7 2024, 12:06 PM
Unknown Object (File)
Dec 28 2023, 2:56 AM
View All 18 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
rohan
Commits
rCOMM30b93384e9d0: [web] introduce light to delete role modal
Summary

This diff introduces light mode to the delete role modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-4841/delete-role-modal

Depends on D10145

Test Plan

Please see screenshots below

dark:

Screenshot 2023-12-01 at 5.27.13 PM.png (1×3 px, 732 KB)

light:

Screenshot 2023-12-01 at 5.26.51 PM.png (1×3 px, 730 KB)

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 1 2023, 2:30 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 1 2023, 2:30 PM
ginsu edited the summary of this revision. (Show Details)Dec 1 2023, 2:49 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a parent revision: D10145: [web] introduce light mode to create/edit role modal.
ginsu attached a referenced file: F906476: Screenshot 2023-12-01 at 5.26.51 PM.png. (Show Details)
Harbormaster completed remote builds in B24714: Diff 34162.Dec 1 2023, 2:49 PM
ginsu requested review of this revision.Dec 1 2023, 2:49 PM
ginsu attached a referenced file: F906475: Screenshot 2023-12-01 at 5.27.13 PM.png. (Show Details)Dec 1 2023, 2:49 PM
ginsu added a child revision: D10149: [web] introduce light mode to app directory modal.Dec 4 2023, 12:22 AM
rohan accepted this revision.Dec 4 2023, 5:44 AM
This revision is now accepted and ready to land.Dec 4 2023, 5:44 AM
ginsu updated this revision to Diff 34349.Dec 6 2023, 10:50 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 6 2023, 10:52 AM
Closed by commit rCOMM30b93384e9d0: [web] introduce light to delete role modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM30b93384e9d0: [web] introduce light to delete role modal.
Harbormaster completed remote builds in B24831: Diff 34349.Dec 6 2023, 11:39 AM

Revision Contents
Changeset List

PathSize
web/
roles/
2 lines

Diff 34353

View Options

web/roles/delete-role-modal.css

Loading...