Differential D10149

[web] introduce light mode to app directory modal
ClosedPublic
Actions

Authored by ginsu on Dec 4 2023, 12:17 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Apr 8 2024, 5:32 AM

	Unknown Object (File)
	Feb 21 2024, 1:39 AM

	Unknown Object (File)
	Feb 21 2024, 12:58 AM

	Unknown Object (File)
	Feb 20 2024, 7:23 PM

	Unknown Object (File)
	Feb 20 2024, 5:01 PM

	Unknown Object (File)
	Feb 20 2024, 11:04 AM

	Unknown Object (File)
	Dec 19 2023, 4:08 PM

	Unknown Object (File)
	Dec 18 2023, 9:24 AM

View All 20 Files

Subscribers

Details

Reviewers

atul
inka
rohan

Commits

rCOMM91f746899548: [web] introduce light mode to app directory modal

Summary

This diff introduces the new color design system/light mode to the app directory modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

linear task: https://linear.app/comm/issue/ENG-5063/app-directory-modal

Depends on D10146

Test Plan

Please see screenshots below

dark:

Screenshot 2023-12-04 at 3.22.04 AM.png (1×3 px, 804 KB)

Screenshot 2023-12-04 at 3.22.00 AM.png (1×3 px, 802 KB)

light:

Screenshot 2023-12-04 at 3.21.35 AM.png (1×3 px, 802 KB)

Screenshot 2023-12-04 at 3.21.30 AM.png (1×3 px, 804 KB)

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ginsu created this revision.Dec 4 2023, 12:17 AM

Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 4 2023, 12:17 AM

ginsu edited the summary of this revision. (Show Details)Dec 4 2023, 12:22 AM

ginsu edited the test plan for this revision. (Show Details)

ginsu added reviewers: atul, inka, rohan.

ginsu added a parent revision: D10146: [web] introduce light to delete role modal.

ginsu attached a referenced file: F908911: Screenshot 2023-12-04 at 3.21.30 AM.png. (Show Details)

ginsu attached a referenced file: F908912: Screenshot 2023-12-04 at 3.21.35 AM.png. (Show Details)

ginsu attached a referenced file: F908913: Screenshot 2023-12-04 at 3.22.00 AM.png. (Show Details)

ginsu attached a referenced file: F908914: Screenshot 2023-12-04 at 3.22.04 AM.png. (Show Details)

ginsu added inline comments.Dec 4 2023, 12:25 AM

web/modals/apps/app-listing.react.js
58–59 ↗	(On Diff #34167)	Small variable name change (thought selected/unselected was a better name)
web/modals/apps/apps.css
8–12 ↗	(On Diff #34167)	Confirmed that this style is not being used/is safe to remove
web/theme.css
129–130 ↗	(On Diff #34167)	Confirmed that these were safe to remove

Harbormaster completed remote builds in B24719: Diff 34167.Dec 4 2023, 12:36 AM

ginsu requested review of this revision.Dec 4 2023, 12:36 AM

rohan accepted this revision.Dec 4 2023, 5:45 AM

This revision is now accepted and ready to land.Dec 4 2023, 5:45 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 6 2023, 10:52 AM

Closed by commit rCOMM91f746899548: [web] introduce light mode to app directory modal (authored by ginsu). · Explain Why

This revision was automatically updated to reflect the committed changes.

ginsu added a commit: rCOMM91f746899548: [web] introduce light mode to app directory modal.

Harbormaster failed remote builds in B24832: Diff 34350!Dec 6 2023, 11:52 AM

Revision Contents
Changeset List

Path

Size

web/

modals/

apps/

app-listing.react.js

4 lines

18 lines

8 lines

Diff 34354

web/modals/apps/app-listing.react.js

Loading...

web/modals/apps/apps.css

Loading...

web/theme.css

Loading...