Page MenuHomePhabricator
Differential D10146

[web] introduce light to delete role modal
ClosedPublic
Actions

Authored by ginsu on Dec 1 2023, 2:30 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Mar 28, 6:54 AM
Unknown Object (File)
Wed, Mar 26, 7:47 PM
Unknown Object (File)
Wed, Mar 26, 7:47 PM
Unknown Object (File)
Wed, Mar 26, 7:46 PM
Unknown Object (File)
Wed, Mar 26, 7:19 PM
Unknown Object (File)
Mon, Mar 24, 10:49 PM
Unknown Object (File)
Fri, Mar 7, 10:56 PM
Unknown Object (File)
Sun, Mar 2, 5:33 PM
View All 89 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
rohan
Commits
rCOMM30b93384e9d0: [web] introduce light to delete role modal
Summary

This diff introduces light mode to the delete role modal

For additional context about this new color design system and the new naming convention here is the notion doc:
https://www.notion.so/commapp/New-Color-System-Proposal-ef80b4e4b9ec42949095056161223a42

Linear task: https://linear.app/comm/issue/ENG-4841/delete-role-modal

Depends on D10145

Test Plan

Please see screenshots below

dark:

Screenshot 2023-12-01 at 5.27.13 PM.png (1×3 px, 732 KB)

light:

Screenshot 2023-12-01 at 5.26.51 PM.png (1×3 px, 730 KB)

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

ginsu created this revision.Dec 1 2023, 2:30 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptDec 1 2023, 2:30 PM
ginsu edited the summary of this revision. (Show Details)Dec 1 2023, 2:49 PM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, rohan.
ginsu added a parent revision: D10145: [web] introduce light mode to create/edit role modal.
ginsu attached a referenced file: F906476: Screenshot 2023-12-01 at 5.26.51 PM.png. (Show Details)
Harbormaster completed remote builds in B24714: Diff 34162.Dec 1 2023, 2:49 PM
ginsu requested review of this revision.Dec 1 2023, 2:49 PM
ginsu attached a referenced file: F906475: Screenshot 2023-12-01 at 5.27.13 PM.png. (Show Details)Dec 1 2023, 2:49 PM
ginsu added a child revision: D10149: [web] introduce light mode to app directory modal.Dec 4 2023, 12:22 AM
rohan accepted this revision.Dec 4 2023, 5:44 AM
This revision is now accepted and ready to land.Dec 4 2023, 5:44 AM
ginsu updated this revision to Diff 34349.Dec 6 2023, 10:50 AM

rebase before landing

This revision was landed with ongoing or failed builds.Dec 6 2023, 10:52 AM
Closed by commit rCOMM30b93384e9d0: [web] introduce light to delete role modal (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMM30b93384e9d0: [web] introduce light to delete role modal.
Harbormaster completed remote builds in B24831: Diff 34349.Dec 6 2023, 11:39 AM

Revision Contents
Changeset List

PathSize
web/
roles/
2 lines

Diff 34349

View Options

web/roles/delete-role-modal.css

Show All 31 Lines egress {
to_port = 0 to_port = 0
protocol = "-1" protocol = "-1"
cidr_blocks = ["0.0.0.0/0"] cidr_blocks = ["0.0.0.0/0"]
} }
} }
# MariaDB RDS Instance # MariaDB RDS Instance
resource "aws_db_instance" "mariadb" { resource "aws_db_instance" "mariadb" {
allocated_storage = 100 allocated_storage = 100
max_allocated_storage = 3000 max_allocated_storage = 3000
storage_type = "gp3" storage_type = "gp3"
db_name = "mariadb" db_name = "mariadb"
identifier = "mariadb-instance" identifier = "mariadb-instance"
engine = "mariadb" engine = "mariadb"
engine_version = "10.11" engine_version = "10.11"
backup_retention_period = 7
instance_class = var.db_instance_class instance_class = var.db_instance_class
db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name db_subnet_group_name = aws_db_subnet_group.public_db_subnet_group.name
vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id] vpc_security_group_ids = [aws_security_group.keyserver_mariadb_security_group.id]
username = local.mariadb_username username = local.mariadb_username
password = local.mariadb_password password = local.mariadb_password
parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name parameter_group_name = aws_db_parameter_group.mariadb_parameter_group.name
storage_encrypted = true storage_encrypted = true
publicly_accessible = true publicly_accessible = true
port = local.mariadb_port port = local.mariadb_port
skip_final_snapshot = true skip_final_snapshot = true
} }
# MariaDB Parameter Group # MariaDB Parameter Group
resource "aws_db_parameter_group" "mariadb_parameter_group" { resource "aws_db_parameter_group" "mariadb_parameter_group" {
name = "mariadb-parameter-group" name = "mariadb-parameter-group"
family = "mariadb10.11" family = "mariadb10.11"
parameter { parameter {
▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines