[native] Remove async IIFE in CommunityDrawerContent effect
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:16 PM.

Details

Reviewers

tomek

Commits

rCOMM1167f5350c24: [native] Remove async IIFE in CommunityDrawerContent effect

Summary

This async IIFE was introduced in D7733. It's not clear to me why we need to await the Promise returned from dispatchActionPromise here, so I'm removing the await here.

If there's a reason for it, I can alternately add a void keyword preceding the async IIFE invocation to silence the unused-promise Flow lint.

Depends on D10173

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 4 2023, 1:16 PM

ashoat added a child revision: D10175: [web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected.

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:49 PM

Harbormaster failed remote builds in B24753: Diff 34216!

Rebase

ashoat published this revision for review.Dec 4 2023, 6:27 PM

Harbormaster completed remote builds in B24769: Diff 34232.Dec 4 2023, 7:25 PM

I don't think there was a good reason behind this await

This revision is now accepted and ready to land.Dec 5 2023, 5:13 AM

Closed by commit rCOMM1167f5350c24: [native] Remove async IIFE in CommunityDrawerContent effect (authored by ashoat). · Explain WhyDec 5 2023, 12:33 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1167f5350c24: [native] Remove async IIFE in CommunityDrawerContent effect.

Revision Contents
Changeset List

Path

Size

native/

navigation/

community-drawer-content.react.js

16 lines

Diff 34308

View Options

native/navigation/community-drawer-content.react.js

[native] Remove async IIFE in CommunityDrawerContent effectClosedPublicActions