Differential D10182 Authored by ashoat on Dec 4 2023, 9:21 PM.
Details Summary The unused-promise Lint identified an issue here. Since we don't handle promise rejections from this code, there is a risk of crashing the keyserver. To avoid that, in this diff I wrap the call with ignorePromiseRejections. Depends on D10181 Test Plan Flow
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 9:21 PM2023-12-04 21:21:03 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 10:02 PM2023-12-04 22:02:42 (UTC+0) Harbormaster completed remote builds in B24777: Diff 34240.Dec 5 2023, 4:52 AM2023-12-05 04:52:01 (UTC+0) This revision is now accepted and ready to land.Dec 5 2023, 2:07 PM2023-12-05 14:07:34 (UTC+0) Closed by commit rCOMM1277963cf3de: [keyserver] Ignore promise rejections from state check mechanism. · Explain WhyDec 5 2023, 8:33 PM2023-12-05 20:33:16 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 34316 |