[keyserver] Ignore promise rejections from state check mechanism
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:21 PM.

Details

Reviewers

michal

Commits

rCOMM1277963cf3de: [keyserver] Ignore promise rejections from state check mechanism

Summary

The unused-promise Lint identified an issue here. Since we don't handle promise rejections from this code, there is a risk of crashing the keyserver.

To avoid that, in this diff I wrap the call with ignorePromiseRejections.

Depends on D10181

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 4 2023, 1:21 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:21 PM

ashoat added a child revision: D10183: [keyserver] Ignore promise rejections from websocket message handler.Dec 4 2023, 1:21 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 2:02 PM

Harbormaster failed remote builds in B24761: Diff 34224!

Rebase

ashoat published this revision for review.Dec 4 2023, 6:28 PM

Harbormaster completed remote builds in B24777: Diff 34240.Dec 4 2023, 8:52 PM

michal accepted this revision.Dec 5 2023, 6:07 AM

This revision is now accepted and ready to land.Dec 5 2023, 6:07 AM

Closed by commit rCOMM1277963cf3de: [keyserver] Ignore promise rejections from state check mechanism (authored by ashoat). · Explain WhyDec 5 2023, 12:33 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM1277963cf3de: [keyserver] Ignore promise rejections from state check mechanism.

Revision Contents
Changeset List

Path

Size

keyserver/

src/

socket/

socket.js

2 lines

Diff 34316

View Options

keyserver/src/socket/socket.js

[keyserver] Ignore promise rejections from state check mechanismClosedPublicActions