Page MenuHomePhabricator
Differential D10182

[keyserver] Ignore promise rejections from state check mechanism
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:21 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Apr 2, 5:57 PM
Unknown Object (File)
Wed, Apr 2, 4:42 AM
Unknown Object (File)
Wed, Mar 12, 6:08 PM
Unknown Object (File)
Feb 19 2025, 5:19 PM
Unknown Object (File)
Feb 19 2025, 5:19 PM
Unknown Object (File)
Feb 19 2025, 5:19 PM
Unknown Object (File)
Feb 19 2025, 5:18 PM
Unknown Object (File)
Feb 19 2025, 5:18 PM
View All 77 Files
Subscribers
tomek

Details

Reviewers
michal
Commits
rCOMM1277963cf3de: [keyserver] Ignore promise rejections from state check mechanism
Summary

The unused-promise Lint identified an issue here. Since we don't handle promise rejections from this code, there is a risk of crashing the keyserver.

To avoid that, in this diff I wrap the call with ignorePromiseRejections.

Depends on D10181

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSize
keyserver/
src/
socket/
2 lines

Diff 34316

View Options

keyserver/src/socket/socket.js

Show All 35 Lines <div className={css.wrapper}>
<TeamProfile <TeamProfile
name="Ashoat Tevosyan" name="Ashoat Tevosyan"
role="Founder" role="Founder"
githubHandle="ashoat" githubHandle="ashoat"
twitterHandle="ashoat" twitterHandle="ashoat"
imageURL={`${assetsCacheURLPrefix}/ashoat.png`} imageURL={`${assetsCacheURLPrefix}/ashoat.png`}
/> />
<TeamProfile <TeamProfile
name="atul"
role="Software Engineer"
githubHandle="atulsmadhugiri"
twitterHandle="atuli0"
imageURL={`${assetsCacheURLPrefix}/atul.jpeg`}
/>
<TeamProfile
name="Varun Dhananjaya" name="Varun Dhananjaya"
role="Software Engineer" role="Software Engineer"
githubHandle="vdhanan" githubHandle="vdhanan"
twitterHandle="_va_run" twitterHandle="_va_run"
imageURL={`${assetsCacheURLPrefix}/varun.jpeg`} imageURL={`${assetsCacheURLPrefix}/varun.jpeg`}
/> />
<TeamProfile <TeamProfile
name="Mark Rafferty" name="William Wang"
role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
/>
<TeamProfile
name="Anunay Kulshrestha"
role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/anunay.jpg`}
/>
<TeamProfile
name="Ginsu Eddy"
role="Software Engineer" role="Software Engineer"
githubHandle="ginsueddy" imageURL={`${assetsCacheURLPrefix}/will.jpg`}
twitterHandle="ginsueddy" githubHandle="wyilio"
imageURL={`${assetsCacheURLPrefix}/ginsu.jpg`}
/> />
<TeamProfile <TeamProfile
name="Rohan Khanderia" name="Yiannis Tselekounis"
role="Software Engineer" role="Research Scientist"
imageURL={`${assetsCacheURLPrefix}/rohan.jpg`} imageURL={`${assetsCacheURLPrefix}/yiannis.jpeg`}
githubHandle="RohanK6"
/> />
<TeamProfile <TeamProfile
name="William Wang" name="Mark Rafferty"
role="Software Engineer" role="Recruiter"
imageURL={`${assetsCacheURLPrefix}/will.jpg`} imageURL={`${assetsCacheURLPrefix}/mark.jpg`}
githubHandle="wyilio"
/> />
</div> </div>
</section> </section>
<h2 className={headerClassName}>Team at Software Mansion</h2> <h2 className={headerClassName}>Team at Software Mansion</h2>
<section className={css.teamWrapper}> <section className={css.teamWrapper}>
<TeamProfile <TeamProfile
name="Tomasz Pałys" name="Tomasz Pałys"
role="Software Engineer" role="Software Engineer"
githubHandle="palys-swm" githubHandle="palys-swm"
imageURL={`${assetsCacheURLPrefix}/tomek.png`} imageURL={`${assetsCacheURLPrefix}/tomek.png`}
/> />
<TeamProfile <TeamProfile
name="Marcin Wasowicz"
role="Software Engineer"
githubHandle="marcinwasowicz"
imageURL={`${assetsCacheURLPrefix}/marcin.jpeg`}
/>
<TeamProfile
name="Inka Sokolowska"
role="Software Engineer"
githubHandle="InkaAlicja"
imageURL={`${assetsCacheURLPrefix}/inka.jpg`}
/>
<TeamProfile
name="Kamil Kurowski" name="Kamil Kurowski"
role="Software Engineer" role="Software Engineer"
githubHandle="xsanm" githubHandle="xsanm"
imageURL={`${assetsCacheURLPrefix}/kamil.jpg`} imageURL={`${assetsCacheURLPrefix}/kamil.jpg`}
/> />
<TeamProfile <TeamProfile
name="Michał Gniadek"
role="Software Engineer"
githubHandle="MichalGniadek"
imageURL={`${assetsCacheURLPrefix}/michał.jpg`}
/>
<TeamProfile
name="Bartłomiej Klocek" name="Bartłomiej Klocek"
role="Software Engineer" role="Software Engineer"
githubHandle="barthap" githubHandle="barthap"
twitterHandle="barthap10" twitterHandle="barthap10"
imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`} imageURL={`${assetsCacheURLPrefix}/bartłomiej.jpg`}
/> />
<TeamProfile <TeamProfile
name="Aleksandra Grzęda" name="Angelika Serwa"
role="Project Manager" role="Software Engineer"
imageURL={`${assetsCacheURLPrefix}/aleksandra.jpg`} githubHandle="graszka22"
imageURL={`${assetsCacheURLPrefix}/angelika.png`}
/> />
<TeamProfile <TeamProfile
name="Monika Kulczyńska" name="Monika Kulczyńska"
role="Project Manager" role="Project Manager"
imageURL={`${assetsCacheURLPrefix}/monika.jpg`} imageURL={`${assetsCacheURLPrefix}/monika.jpg`}
/> />
</section> </section>
</div> </div>
); );
} }
export default Team; export default Team;