Page MenuHomePhabricator

[web] Don't handle promise for onDeviceTokenRegistered call in PushNotifsHandler
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:11 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 26, 1:16 AM
Unknown Object (File)
Mon, Nov 25, 4:15 PM
Unknown Object (File)
Nov 13 2024, 12:35 AM
Unknown Object (File)
Nov 7 2024, 6:00 PM
Unknown Object (File)
Oct 16 2024, 5:53 PM
Unknown Object (File)
Oct 16 2024, 5:53 PM
Unknown Object (File)
Oct 16 2024, 5:53 PM
Unknown Object (File)
Oct 16 2024, 5:52 PM
Subscribers

Details

Summary

Separating this out because it might need more detailed review.

There's a question I asked Michal on Linear about whether Electron apps crash on unhandled promise rejections like Node.js does. If the answer is "no", then there's no issue here.

If the answer is "yes", then it depends on whether the callback we pass to onDeviceTokenRegistered gets executed on desktop or on web. My impression the ElectronBridge stuff is that it gets executed on web still, in which case there's still no issue here.

Depends on D10163

Test Plan

Flow; analysis in diff description

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable