Page MenuHomePhabricator
Differential D10176

[lib][native][web][landing] Silence unused-promise using void keyword
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 6:00 PM
Unknown Object (File)
Tue, Oct 29, 12:11 AM
Unknown Object (File)
Oct 16 2024, 5:58 PM
Unknown Object (File)
Oct 16 2024, 5:58 PM
Unknown Object (File)
Oct 16 2024, 5:57 PM
Unknown Object (File)
Oct 16 2024, 5:57 PM
Unknown Object (File)
Oct 16 2024, 5:57 PM
Unknown Object (File)
Oct 16 2024, 5:57 PM
View All Files
Subscribers
tomek

Details

Reviewers
michal
Commits
rCOMM409a2b6e2a8f: [lib][native][web][landing] Silence unused-promise using void keyword
Summary

The Flow team recommends using the void keyword to silence the unused-promise Lint. See the "Fire-and-forget" part of this blog post.

In this diff, I add the void keyword to a bunch of places in native, web, landing, and the parts of lib that are only used from native/web/landing. In these contexts it's safe to ignore promise rejections, because unlike Node.js there are no negative consequences to it. In contrast, we need to be more careful in keyserver (and potentially desktop?) because Node.js will crash when it encounters an unhandled promise rejection.

Depends on D10175

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 4 2023, 1:17 PM
Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:17 PM
ashoat added a child revision: D10177: [keyserver] Ignore potential to crash on promise rejections in scripts.Dec 4 2023, 1:18 PM
Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:52 PM
Harbormaster failed remote builds in B24755: Diff 34218!
ashoat updated this revision to Diff 34234.Dec 4 2023, 4:23 PM

Rebase

ashoat published this revision for review.Dec 4 2023, 6:27 PM
Harbormaster completed remote builds in B24771: Diff 34234.Dec 4 2023, 7:45 PM
michal accepted this revision.Dec 5 2023, 5:44 AM
michal added inline comments.
lib/components/base-edit-thread-avatar-provider.react.js
86–89 ↗(On Diff #34234)

Unrelated, but is there a reason why we await the promise directly instead of dispatchActionPromise? It seems like it would work the same.

This revision is now accepted and ready to land.Dec 5 2023, 5:44 AM
ashoat added inline comments.Dec 5 2023, 10:31 AM
lib/components/base-edit-thread-avatar-provider.react.js
86–89 ↗(On Diff #34234)

I had the same thought, but I wasn't sure enough to make this change. It seems to depend on the internals of react-redux/redux-thunk and I didn't have time to delve into it

ashoat updated this revision to Diff 34292.Dec 5 2023, 12:27 PM

Rebase

This revision was landed with ongoing or failed builds.Dec 5 2023, 12:33 PM
Closed by commit rCOMM409a2b6e2a8f: [lib][native][web][landing] Silence unused-promise using void keyword (authored by ashoat). · Explain Why
This revision was automatically updated to reflect the committed changes.
ashoat added a commit: rCOMM409a2b6e2a8f: [lib][native][web][landing] Silence unused-promise using void keyword.
Harbormaster completed remote builds in B24812: Diff 34292.Dec 5 2023, 12:48 PM

Large Diff

This large diff affects 136 files. Files without inline comments have been collapsed. Expand All Files

Revision Contents
Changeset List

PathSize
landing/
2 lines
2 lines
lib/
components/
2 lines
2 lines
hooks/
2 lines
6 lines
4 lines
2 lines
2 lines
2 lines
shared/
2 lines
5 lines
2 lines
messages/
5 lines
9 lines
8 lines
socket/
2 lines
2 lines
2 lines
6 lines
12 lines
utils/
4 lines
2 lines
native/
account/
4 lines
4 lines
6 lines
registration/
2 lines
2 lines
4 lines
4 lines
2 lines
2 lines
4 lines
4 lines
android/
2 lines
backup/
2 lines
calendar/
6 lines
8 lines
chat/
5 lines
2 lines
2 lines
2 lines
5 lines
2 lines
2 lines
settings/
5 lines
2 lines
2 lines
4 lines
2 lines
2 lines
2 lines
2 lines
4 lines
2 lines
2 lines
community-creation/
2 lines
2 lines
components/
4 lines
7 lines
12 lines
data/
4 lines
input/
16 lines
keyboard/
2 lines
markdown/
2 lines
media/
8 lines
4 lines
6 lines
2 lines
14 lines
navigation/
2 lines
9 lines
5 lines
profile/
2 lines
5 lines
2 lines
2 lines
2 lines
2 lines
2 lines
2 lines
push/
10 lines
qr-code/
2 lines
redux/
2 lines
2 lines
roles/
2 lines
2 lines
2 lines
4 lines
2 lines
utils/
2 lines
2 lines
web/
account/
2 lines
2 lines
2 lines
2 lines
2 lines
calendar/
4 lines
6 lines
chat/
7 lines
4 lines
4 lines
2 lines
2 lines
2 lines
database/
2 lines
2 lines
worker/
2 lines
input/
22 lines
invite-links/
5 lines
7 lines
2 lines
media/
2 lines
2 lines
2 lines
modals/
chat/
2 lines
2 lines
history/
2 lines
4 lines
threads/
gallery/
2 lines
members/
2 lines
2 lines
notifications/
2 lines
settings/
2 lines
2 lines
2 lines
2 lines
push-notif/
6 lines
redux/
2 lines
2 lines
2 lines
roles/
2 lines
2 lines
settings/
2 lines
2 lines
sidebar/
community-creation/
2 lines

Diff 34311

View Options

landing/keyservers.react.js

View Options

landing/siwe.react.js

View Options

lib/components/base-edit-thread-avatar-provider.react.js

View Options

lib/components/edit-user-avatar-provider.react.js

View Options

lib/hooks/child-threads.js

View Options

lib/hooks/ens-cache.js

View Options

lib/hooks/invite-links.js

View Options

lib/hooks/promote-sidebar.react.js

View Options

lib/hooks/relationship-prompt.js

View Options

lib/hooks/toggle-unread-status.js

View Options

lib/shared/crypto-utils.js

View Options

lib/shared/edit-messages-utils.js

View Options

lib/shared/keyserver-utils.js

View Options

lib/shared/messages/text-message-spec.js

View Options

lib/shared/search-utils.js

View Options

lib/shared/thread-utils.js

View Options

lib/socket/activity-handler.react.js

View Options

lib/socket/calendar-query-handler.react.js

View Options

lib/socket/report-handler.react.js

View Options

lib/socket/request-response-handler.react.js

View Options

lib/socket/socket.react.js

View Options

lib/utils/action-utils.js

View Options

lib/utils/policy-acknowledge-utlis.js

View Options

native/account/log-in-panel.react.js

View Options

native/account/logged-out-modal.react.js

View Options

native/account/register-panel.react.js

View Options

native/account/registration/connect-ethereum.react.js

View Options

native/account/registration/password-selection.react.js

View Options

native/account/registration/registration-server-call.js

View Options

native/account/registration/registration-terms.react.js

View Options

native/account/registration/username-selection.react.js

View Options

native/account/siwe-hooks.js

View Options

native/account/siwe-panel.react.js

View Options

native/account/terms-and-privacy-modal.react.js

View Options

native/android/upload-aab.js

View Options

native/backup/backup-handler.js

View Options

native/calendar/calendar.react.js

View Options

native/calendar/entry.react.js

View Options

native/chat/chat-input-bar.react.js

View Options

native/chat/compose-subchannel.react.js

View Options

native/chat/failed-send.react.js

View Options

native/chat/message-list.react.js

View Options

native/chat/message-report-utils.js

View Options

native/chat/message-results-screen.react.js

View Options

native/chat/reaction-message-utils.js

View Options

native/chat/settings/add-users-modal.react.js

View Options

native/chat/settings/color-selector-modal.react.js

View Options

native/chat/settings/delete-thread.react.js

View Options

native/chat/settings/thread-settings-description.react.js

View Options

native/chat/settings/thread-settings-edit-relationship.react.js

View Options

native/chat/settings/thread-settings-home-notifs.react.js

View Options

native/chat/settings/thread-settings-leave-thread.react.js

View Options

native/chat/settings/thread-settings-media-gallery.react.js

View Options

native/chat/settings/thread-settings-name.react.js

View Options

native/chat/settings/thread-settings-push-notifs.react.js

View Options

native/chat/toggle-pin-modal.react.js

View Options

native/community-creation/community-configuration.react.js

View Options

native/community-creation/community-creation-members.react.js

View Options

native/components/feature-flags-provider.react.js

View Options

native/components/version-supported.react.js

View Options

native/crash.react.js

View Options

native/data/sqlite-data-handler.js

View Options

native/input/input-state-container.react.js

View Options

native/keyboard/keyboard-state-container.react.js

View Options

native/markdown/markdown-utils.js

View Options

native/media/camera-modal.react.js

View Options

native/media/encrypted-image.react.js

View Options

native/media/media-gallery-keyboard.react.js

View Options

native/media/video-playback-modal.react.js

View Options

native/media/video-utils.js

View Options

native/navigation/app-navigator.react.js

View Options

native/navigation/deep-links-context-provider.react.js

View Options

native/navigation/invite-link-modal.react.js

View Options

native/profile/default-notifications-preferences.react.js

View Options

native/profile/delete-account.react.js

View Options

native/profile/edit-password.react.js

View Options

native/profile/profile-screen.react.js

View Options

native/profile/relationship-list-item.react.js

View Options

native/profile/relationship-list.react.js

View Options

native/profile/secondary-device-qr-code-scanner.react.js

View Options

native/profile/user-relationship-tooltip-modal.react.js

View Options

native/push/push-handler.react.js

View Options

native/qr-code/qr-code-screen.react.js

View Options

native/redux/persist.js

View Options

native/redux/redux-setup.js

View Options

native/roles/change-roles-header-right-button.react.js

View Options

native/roles/create-roles-header-right-button.react.js

View Options

native/roles/role-utils.react.js

View Options

native/root.react.js

View Options

native/socket.react.js

View Options

native/utils/hooks.js

View Options

native/utils/tunnelbroker-utils.js

View Options

web/account/log-in-form.react.js

View Options

web/account/qr-code-login.react.js

View Options

web/account/siwe-login-form.react.js

View Options

web/account/traditional-login-form.react.js

View Options

web/app.react.js

View Options

web/calendar/calendar.react.js

View Options

web/calendar/entry.react.js

View Options

web/chat/chat-input-bar.react.js

View Options

web/chat/chat-message-list-container.react.js

View Options

web/chat/chat-message-list.react.js

View Options

web/chat/failed-send.react.js

View Options

web/chat/reaction-message-utils.js

View Options

web/chat/thread-menu.react.js

View Options

web/database/database-module-provider.js

View Options

web/database/sqlite-data-handler.js

View Options

web/database/worker/db-worker.js

View Options

web/input/input-state-container.react.js

View Options

web/invite-links/accept-invite-modal.react.js

View Options

web/invite-links/invite-link-handler.react.js

View Options

web/invite-links/invite-links-refresher.react.js

View Options

web/media/encrypted-multimedia.react.js

View Options

web/media/loadable-video.react.js

View Options

web/media/media-utils.js

View Options

web/modals/chat/message-results-modal.react.js

View Options

web/modals/chat/toggle-pin-modal.react.js

View Options

web/modals/history/history-entry.react.js

View Options

web/modals/history/history-modal.react.js

View Options

web/modals/threads/gallery/thread-settings-media-gallery.react.js

View Options

web/modals/threads/members/add-members-modal.react.js

View Options

web/modals/threads/members/change-member-role-modal.react.js

View Options

web/modals/threads/notifications/notifications-modal.react.js

View Options

web/modals/threads/settings/thread-settings-delete-tab.react.js

View Options

web/modals/threads/settings/thread-settings-general-tab.react.js

View Options

web/modals/threads/settings/thread-settings-privacy-tab.react.js

View Options

web/modals/threads/settings/thread-settings-relationship-button.react.js

View Options

web/push-notif/push-notifs-handler.js

View Options

web/redux/initial-state-gate.js

View Options

web/redux/redux-setup.js

View Options

web/redux/visibility.js

View Options

web/roles/create-roles-modal.react.js

View Options

web/roles/delete-role-modal.react.js

View Options

web/settings/account-delete-modal.react.js

View Options

web/settings/password-change-modal.js

View Options

web/sidebar/community-creation/community-creation-modal.react.js