Page MenuHomePhabricator
Differential D10175

[web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:17 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Apr 19, 4:20 PM
Unknown Object (File)
Sat, Apr 19, 2:31 PM
Unknown Object (File)
Sat, Apr 19, 7:28 AM
Unknown Object (File)
Fri, Apr 18, 11:05 PM
Unknown Object (File)
Fri, Apr 18, 10:17 AM
Unknown Object (File)
Fri, Apr 18, 12:14 AM
Unknown Object (File)
Wed, Apr 9, 12:31 AM
Unknown Object (File)
Tue, Apr 8, 8:35 PM
View All 91 Files
Subscribers
tomek

Details

Reviewers
atul
ginsu
michal
Commits
rCOMM1f86a1b1dc52: [web] await baseSetThreadAvatar/baseSetUserAvatar in onImageSelected
Summary

We could add a void here instead, but onImageSelected is already an async function, and the place we're passing it to doesn't await the result anyways. So might as well just add an await keyword.

Depends on D10174

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

Diff 34309

View Options

web/avatars/edit-thread-avatar-menu.react.js

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
function assertWithValidator<T>(data: mixed, validator: TType<T>): T { function assertWithValidator<T>(data: mixed, validator: TType<T>): T {
invariant(validator.is(data), "data isn't of type T"); invariant(validator.is(data), "data isn't of type T");
return (data: any); return (data: any);
} }
const ashoatKeyserverID = '256'; const ashoatKeyserverID = '256';
const idSchemaRegex = '(?:[0-9]+\\|)?[0-9]+'; const uuidRegex =
'[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}';
const idSchemaRegex = `(?:(?:[0-9]+|${uuidRegex})\\|)?(?:[0-9]+|${uuidRegex})`;
const pendingThreadIDRegex = `pending/(type[0-9]+/[0-9]+(\\+[0-9]+)*|sidebar/${idSchemaRegex})`; const pendingThreadIDRegex = `pending/(type[0-9]+/[0-9]+(\\+[0-9]+)*|sidebar/${idSchemaRegex})`;
const chatNameMaxLength = 191; const chatNameMaxLength = 191;
const chatNameMinLength = 0; const chatNameMinLength = 0;
const secondCharRange = `{${chatNameMinLength},${chatNameMaxLength}}`; const secondCharRange = `{${chatNameMinLength},${chatNameMaxLength}}`;
const validChatNameRegexString = `.${secondCharRange}`; const validChatNameRegexString = `.${secondCharRange}`;
const validChatNameRegex: RegExp = new RegExp(`^${validChatNameRegexString}$`); const validChatNameRegex: RegExp = new RegExp(`^${validChatNameRegexString}$`);
Show All 31 Lines
View Options

web/avatars/edit-user-avatar-menu.react.js

Show First 20 Lines • Show All 102 Lines • ▼ Show 20 Lines
function assertWithValidator<T>(data: mixed, validator: TType<T>): T { function assertWithValidator<T>(data: mixed, validator: TType<T>): T {
invariant(validator.is(data), "data isn't of type T"); invariant(validator.is(data), "data isn't of type T");
return (data: any); return (data: any);
} }
const ashoatKeyserverID = '256'; const ashoatKeyserverID = '256';
const idSchemaRegex = '(?:[0-9]+\\|)?[0-9]+'; const uuidRegex =
'[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}';
const idSchemaRegex = `(?:(?:[0-9]+|${uuidRegex})\\|)?(?:[0-9]+|${uuidRegex})`;
const pendingThreadIDRegex = `pending/(type[0-9]+/[0-9]+(\\+[0-9]+)*|sidebar/${idSchemaRegex})`; const pendingThreadIDRegex = `pending/(type[0-9]+/[0-9]+(\\+[0-9]+)*|sidebar/${idSchemaRegex})`;
const chatNameMaxLength = 191; const chatNameMaxLength = 191;
const chatNameMinLength = 0; const chatNameMinLength = 0;
const secondCharRange = `{${chatNameMinLength},${chatNameMaxLength}}`; const secondCharRange = `{${chatNameMinLength},${chatNameMaxLength}}`;
const validChatNameRegexString = `.${secondCharRange}`; const validChatNameRegexString = `.${secondCharRange}`;
const validChatNameRegex: RegExp = new RegExp(`^${validChatNameRegexString}$`); const validChatNameRegex: RegExp = new RegExp(`^${validChatNameRegexString}$`);
Show All 31 Lines