[native] Return inputState.sendMultimediaMessage Promise directly in ChatCameraModal
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:16 PM.

Details

Reviewers

atul
michal

Commits

rCOMM7d8c0e0ae555: [native] Return inputState.sendMultimediaMessage Promise directly in…

Summary

The API of CameraModal doesn't care what the function returns, so we might as well return the Promise directly, as an alternative to prefixing with void.

Depends on D10171

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

ashoat created this revision.Dec 4 2023, 1:16 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:16 PM

ashoat added a child revision: D10174: [native] Remove async IIFE in CommunityDrawerContent effect.Dec 4 2023, 1:16 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:47 PM

Harbormaster failed remote builds in B24752: Diff 34215!

Rebase

ashoat published this revision for review.Dec 4 2023, 6:27 PM

Harbormaster failed remote builds in B24768: Diff 34231!Dec 4 2023, 7:22 PM

michal accepted this revision.Dec 5 2023, 2:57 AM

This revision is now accepted and ready to land.Dec 5 2023, 2:57 AM

This revision was landed with ongoing or failed builds.Dec 5 2023, 12:33 PM

Closed by commit rCOMM7d8c0e0ae555: [native] Return inputState.sendMultimediaMessage Promise directly in… (authored by ashoat). · Explain Why

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM7d8c0e0ae555: [native] Return inputState.sendMultimediaMessage Promise directly in….

Revision Contents
Changeset List

Path

Size

native/

media/

chat-camera-modal.react.js

2 lines

Diff 34307

View Options

native/media/chat-camera-modal.react.js

Show First 20 Lines • Show All 266 Lines • ▼ Show 20 Lines	const operation: ReplaceKeyserverOperation = {
},		},
},		},
};		};
return {		return {
...state,		...state,
keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),		keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
};		};
} else if (action.type === keyserverRegisterActionTypes.success) {		} else if (action.type === keyserverRegisterActionTypes.success) {
state = {		const operation: ReplaceKeyserverOperation = {
...state,		type: 'replace_keyserver',
keyserverInfos: {		payload: {
...state.keyserverInfos,		id: ashoatKeyserverID,
[ashoatKeyserverID]: {		keyserverInfo: {
...state.keyserverInfos[ashoatKeyserverID],		...state.keyserverInfos[ashoatKeyserverID],
lastCommunicatedPlatformDetails: getConfig().platformDetails,		lastCommunicatedPlatformDetails: getConfig().platformDetails,
},		},
},		},
};		};
		return {
		...state,
		keyserverInfos: processStoreOps(state.keyserverInfos, [operation]),
		};
} else if (action.type === updateConnectionStatusActionType) {		} else if (action.type === updateConnectionStatusActionType) {
const { keyserverID, status } = action.payload;		const { keyserverID, status } = action.payload;
return {		return {
...state,		...state,
keyserverInfos: {		keyserverInfos: {
...state.keyserverInfos,		...state.keyserverInfos,
[keyserverID]: {		[keyserverID]: {
...state.keyserverInfos[keyserverID],		...state.keyserverInfos[keyserverID],
▲ Show 20 Lines • Show All 204 Lines • Show Last 20 Lines

[native] Return inputState.sendMultimediaMessage Promise directly in ChatCameraModalClosedPublicActions