While working on the unused-promise Flow lint, I noticed that there is no await keyword here, so there's no point to it being an async function.
Depends on D10169
Differential D10170 Authored by ashoat on Dec 4 2023, 9:15 PM.
Details Summary While working on the unused-promise Flow lint, I noticed that there is no await keyword here, so there's no point to it being an async function. Depends on D10169 Test Plan Flow
Diff Detail
Event TimelineHerald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 9:15 PM2023-12-04 21:15:08 (UTC+0) Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 9:42 PM2023-12-04 21:42:03 (UTC+0) Harbormaster completed remote builds in B24766: Diff 34229.Dec 5 2023, 2:52 AM2023-12-05 02:52:21 (UTC+0) This revision is now accepted and ready to land.Dec 5 2023, 10:55 AM2023-12-05 10:55:54 (UTC+0) Closed by commit rCOMM27f414488c8e: [native] Don't make Crash.onPressWipe an async function. · Explain WhyDec 5 2023, 8:32 PM2023-12-05 20:32:58 (UTC+0) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 34305 |