[native] Don't make Crash.onPressWipe an async function
ClosedPublic
Actions

Authored by ashoat on Dec 4 2023, 1:15 PM.

Details

Reviewers

bartek
michal

Commits

rCOMM27f414488c8e: [native] Don't make Crash.onPressWipe an async function

Summary

While working on the unused-promise Flow lint, I noticed that there is no await keyword here, so there's no point to it being an async function.

Depends on D10169

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

ashoat created this revision.Dec 4 2023, 1:15 PM

Herald added a subscriber: tomek. · View Herald TranscriptDec 4 2023, 1:15 PM

ashoat added a child revision: D10171: [native] await sendMultimediaMessage in KeyboardInputHost.onMediaGalleryItemSelected.Dec 4 2023, 1:15 PM

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:42 PM

Harbormaster failed remote builds in B24749: Diff 34212!

Rebase

ashoat published this revision for review.Dec 4 2023, 6:27 PM

Harbormaster completed remote builds in B24766: Diff 34229.Dec 4 2023, 6:52 PM

michal accepted this revision.Dec 5 2023, 2:55 AM

This revision is now accepted and ready to land.Dec 5 2023, 2:55 AM

Closed by commit rCOMM27f414488c8e: [native] Don't make Crash.onPressWipe an async function (authored by ashoat). · Explain WhyDec 5 2023, 12:32 PM

This revision was automatically updated to reflect the committed changes.

ashoat added a commit: rCOMM27f414488c8e: [native] Don't make Crash.onPressWipe an async function.

Revision Contents
Changeset List

Path

Size

native/

crash.react.js

2 lines

Diff 34229

View Options

native/crash.react.js

// @flow		// @flow

import * as React from 'react';		import * as React from 'react';
import { View, Text } from 'react-native';		import { View, Text } from 'react-native';
import QRCode from 'react-native-qrcode-svg';		import QRCode from 'react-native-qrcode-svg';

import { qrCodeLinkURL } from 'lib/facts/links.js';		import { qrCodeLinkURL } from 'lib/facts/links.js';
import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js';		import { useSecondaryDeviceLogIn } from 'lib/hooks/login-hooks.js';
import { useQRAuth } from 'lib/hooks/qr-auth.js';		import { useQRAuth } from 'lib/hooks/qr-auth.js';
import { uintArrayToHexString } from 'lib/media/data-utils.js';		import { uintArrayToHexString } from 'lib/media/data-utils.js';
import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';		import { useTunnelbroker } from 'lib/tunnelbroker/tunnelbroker-context.js';
import type { BackupKeys } from 'lib/types/backup-types.js';		import type { BackupKeys } from 'lib/types/backup-types.js';
import { getContentSigningKey } from 'lib/utils/crypto-utils.js';		import { getContentSigningKey } from 'lib/utils/crypto-utils.js';
		import { getMessageForException } from 'lib/utils/errors.js';

import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js';		import type { QRCodeSignInNavigationProp } from './qr-code-sign-in-navigator.react.js';
import {		import {
composeTunnelbrokerQRAuthMessage,		composeTunnelbrokerQRAuthMessage,
parseTunnelbrokerQRAuthMessage,		parseTunnelbrokerQRAuthMessage,
} from './qr-code-utils.js';		} from './qr-code-utils.js';
import { commCoreModule } from '../native-modules.js';		import { commCoreModule } from '../native-modules.js';
import type { NavigationRoute } from '../navigation/route-names.js';		import type { NavigationRoute } from '../navigation/route-names.js';
import { useStyles } from '../themes/colors.js';		import { useStyles } from '../themes/colors.js';
import * as AES from '../utils/aes-crypto-module.js';		import * as AES from '../utils/aes-crypto-module.js';
		import {
		appOutOfDateAlertDetails,
		unknownErrorAlertDetails,
		} from '../utils/alert-messages.js';
import Alert from '../utils/alert.js';		import Alert from '../utils/alert.js';

type QRCodeScreenProps = {		type QRCodeScreenProps = {
+navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>,		+navigation: QRCodeSignInNavigationProp<'QRCodeScreen'>,
+route: NavigationRoute<'QRCodeScreen'>,		+route: NavigationRoute<'QRCodeScreen'>,
};		};

function performBackupRestore(backupKeys: BackupKeys): Promise<void> {		function performBackupRestore(backupKeys: BackupKeys): Promise<void> {
Show All 28 Lines	function QRCodeScreen(props: QRCodeScreenProps): React.Node {

const secondaryDeviceLogIn = useSecondaryDeviceLogIn();		const secondaryDeviceLogIn = useSecondaryDeviceLogIn();
const performRegistration = React.useCallback(		const performRegistration = React.useCallback(
async (userID: string) => {		async (userID: string) => {
try {		try {
await secondaryDeviceLogIn(userID);		await secondaryDeviceLogIn(userID);
} catch (err) {		} catch (err) {
console.error('Secondary device registration error:', err);		console.error('Secondary device registration error:', err);
Alert.alert('Registration failed', 'Failed to upload device keys', [		const messageForException = getMessageForException(err);
{ text: 'OK' },		if (
]);		messageForException === 'client_version_unsupported' \|\|
		messageForException === 'Unsupported version'
		) {
		Alert.alert(
		appOutOfDateAlertDetails.title,
		appOutOfDateAlertDetails.message,
		);
		} else {
		Alert.alert(
		unknownErrorAlertDetails.title,
		unknownErrorAlertDetails.message,
		);
		}
void generateQRCode();		void generateQRCode();
}		}
},		},
[secondaryDeviceLogIn, generateQRCode],		[secondaryDeviceLogIn, generateQRCode],
);		);

React.useEffect(() => {		React.useEffect(() => {
void generateQRCode();		void generateQRCode();
▲ Show 20 Lines • Show All 89 Lines • Show Last 20 Lines

[native] Don't make Crash.onPressWipe an async functionClosedPublicActions