Page MenuHomePhabricator

[native] Remove async IIFE in CommunityDrawerContent effect
ClosedPublic

Authored by ashoat on Dec 4 2023, 1:16 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 7, 6:00 PM
Unknown Object (File)
Oct 16 2024, 5:54 PM
Unknown Object (File)
Oct 16 2024, 5:54 PM
Unknown Object (File)
Oct 16 2024, 5:54 PM
Unknown Object (File)
Oct 16 2024, 5:53 PM
Unknown Object (File)
Oct 16 2024, 5:52 PM
Unknown Object (File)
Oct 14 2024, 9:53 PM
Unknown Object (File)
Oct 7 2024, 1:04 PM
Subscribers
None

Details

Summary

This async IIFE was introduced in D7733. It's not clear to me why we need to await the Promise returned from dispatchActionPromise here, so I'm removing the await here.

If there's a reason for it, I can alternately add a void keyword preceding the async IIFE invocation to silence the unused-promise Flow lint.

Depends on D10173

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

Harbormaster returned this revision to the author for changes because remote builds failed.Dec 4 2023, 1:49 PM
Harbormaster failed remote builds in B24753: Diff 34216!
ashoat published this revision for review.Dec 4 2023, 6:27 PM

I don't think there was a good reason behind this await

This revision is now accepted and ready to land.Dec 5 2023, 5:13 AM