Page MenuHomePhabricator

[web] Introduce deviceID parameter to initial notif message function
ClosedPublic

Authored by tomek on Jan 17 2024, 6:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 20 2024, 5:01 PM
Unknown Object (File)
Feb 20 2024, 4:31 PM
Unknown Object (File)
Feb 20 2024, 3:58 PM
Unknown Object (File)
Feb 20 2024, 1:52 PM
Unknown Object (File)
Feb 20 2024, 7:00 AM
Unknown Object (File)
Feb 17 2024, 1:46 AM
Unknown Object (File)
Feb 8 2024, 4:09 AM
Unknown Object (File)
Feb 7 2024, 6:22 PM
Subscribers

Details

Summary

Similar to D10660 but for web.

Depends on D10660

Test Plan

Check if encrypted notifs work on web.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek held this revision as a draft.
tomek published this revision for review.Jan 17 2024, 8:51 AM
This revision is now accepted and ready to land.Jan 18 2024, 7:31 AM
kamil added a subscriber: kamil.

Using deviceID everywhere makes me sometimes confused which ID it is, so in places like this I would prefer recipientDeviceID or targetDeviceID but curious about what other reviewers think.

I did the same here D10381 so going to update next time touching this code.

Using deviceID everywhere makes me sometimes confused which ID it is, so in places like this I would prefer recipientDeviceID or targetDeviceID but curious about what other reviewers think.

I did the same here D10381 so going to update next time touching this code.

For notfis, it might make sense to have a keyserverID for now - https://phab.comm.dev/D10660#309743