[native][web] Make identity client mandatory
ClosedPublic
Actions

Authored by tomek on Jan 17 2024, 4:03 PM.

Details

Reviewers

varun
inka
kamil
ashoat

Commits

rCOMMd5ef4a27085a: [native][web] Make identity client mandatory

Summary

Replace effect with memo and make the value mandatory which simplifies its usage.

Depends on D10663

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jan 17 2024, 4:03 PM

Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2024, 4:03 PM

tomek removed a reviewer: marcin.Jan 17 2024, 4:06 PM

tomek added a child revision: D10665: [lib] Improve error handling in connection handler.Jan 17 2024, 4:07 PM

Harbormaster completed remote builds in B25837: Diff 35726.Jan 17 2024, 4:21 PM

tomek requested review of this revision.Jan 17 2024, 4:21 PM

ashoat accepted this revision.Jan 17 2024, 4:24 PM

ashoat added inline comments.

native/identity-service/identity-service-context-provider.react.js
63–91 ↗	(On Diff #35726)	Nit: this can be slightly simplified

This revision is now accepted and ready to land.Jan 17 2024, 4:24 PM

Simplify

Harbormaster completed remote builds in B25907: Diff 35808.Jan 18 2024, 6:08 PM

Rebase

Harbormaster completed remote builds in B25952: Diff 35874.Jan 19 2024, 2:40 PM

Closed by commit rCOMMd5ef4a27085a: [native][web] Make identity client mandatory. · Explain WhyJan 19 2024, 4:03 PM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMd5ef4a27085a: [native][web] Make identity client mandatory.

Revision Contents
Changeset List

Path

Size

lib/

shared/

identity-client-context.js

2 lines

native/

identity-service/

identity-service-context-provider.react.js

9 lines

web/

grpc/

identity-service-context-provider.react.js

6 lines

Diff 35886

View Options

lib/shared/identity-client-context.js

View Options

native/identity-service/identity-service-context-provider.react.js

View Options

web/grpc/identity-service-context-provider.react.js

[native][web] Make identity client mandatoryClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 35886

lib/shared/identity-client-context.js

native/identity-service/identity-service-context-provider.react.js

web/grpc/identity-service-context-provider.react.js

[native][web] Make identity client mandatory
ClosedPublic
Actions

Revision Contents
Changeset List