[lib] Improve error handling in connection handler
ClosedPublic
Actions

Authored by tomek on Jan 17 2024, 8:07 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 22, 12:49 PM

	Unknown Object (File)
	Wed, May 22, 12:48 PM

	Unknown Object (File)
	Wed, May 22, 12:48 PM

	Unknown Object (File)
	Wed, May 22, 12:48 PM

	Unknown Object (File)
	Wed, May 22, 12:48 PM

	Unknown Object (File)
	Feb 28 2024, 5:49 PM

	Unknown Object (File)
	Feb 20 2024, 8:53 PM

	Unknown Object (File)
	Feb 20 2024, 8:27 PM

View All 16 Files

Subscribers

ashoat

Details

Reviewers

varun
inka
kamil

Commits

rCOMMaf7c614948c2: [lib] Improve error handling in connection handler

Summary

It is an error when identity client context value isn't set here.

Depends on D10664

Test Plan

Flow

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jan 17 2024, 8:07 AM

tomek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2024, 8:07 AM

tomek added a child revision: D10666: [lib][native][web] Parse keyserver keys payload and validate the result.Jan 17 2024, 8:10 AM

Harbormaster completed remote builds in B25838: Diff 35727.Jan 17 2024, 8:25 AM

tomek published this revision for review.Jan 17 2024, 8:52 AM

inka accepted this revision.Jan 18 2024, 2:58 AM

This revision is now accepted and ready to land.Jan 18 2024, 2:58 AM

Rebase

Harbormaster completed remote builds in B25953: Diff 35875.Jan 19 2024, 6:41 AM

Closed by commit rCOMMaf7c614948c2: [lib] Improve error handling in connection handler (authored by tomek). · Explain WhyJan 19 2024, 8:03 AM

This revision was automatically updated to reflect the committed changes.

tomek added a commit: rCOMMaf7c614948c2: [lib] Improve error handling in connection handler.

Revision Contents
Changeset List

Path

Size

lib/

components/

keyserver-connection-handler.js

5 lines

Diff 35887

View Options

lib/components/keyserver-connection-handler.js

[lib] Improve error handling in connection handlerClosedPublicActions