[lib][native] Introduce deviceID parameter to initial notif message function
ClosedPublic
Actions

Authored by tomek on Jan 17 2024, 6:51 AM.

Details

Reviewers

varun
marcin
kamil

Commits

rCOMM50b762fbe2de: [lib][native] Introduce deviceID parameter to initial notif message function

Summary

This function will be used in connection handlers which are aware of the device id. This diff doesn't change any logic - the actual changes will be handled as a part of preparing notifs for multiple keyservers.

Test Plan

Check if encrypted notifs are received by iOS device.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tomek created this revision.Jan 17 2024, 6:51 AM

tomek held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2024, 6:51 AM

tomek added a child revision: D10662: [web] Introduce deviceID parameter to initial notif message function.Jan 17 2024, 6:59 AM

Harbormaster completed remote builds in B25833: Diff 35722.Jan 17 2024, 7:12 AM

tomek published this revision for review.Jan 17 2024, 8:50 AM

varun accepted this revision.Jan 18 2024, 7:28 AM

This revision is now accepted and ready to land.Jan 18 2024, 7:28 AM

Same concern as here: https://phab.comm.dev/D10662#309232

marcin added inline comments.Jan 19 2024, 3:03 AM

lib/keyserver-conn/recovery-utils.js
49 ↗	(On Diff #35722)	Name of this parameter is quite confusing. Is it possible to rename it something that makes it clear this is the keyserver ID?

marcin accepted this revision.Jan 19 2024, 3:03 AM

tomek added inline comments.Jan 19 2024, 4:56 AM

lib/keyserver-conn/recovery-utils.js
49 ↗	(On Diff #35722)	In the future, we should be able to have a notif session with any device, not just the keyserver. But then, we will be creating two notif sessions, so this code will be changed regardless. So for now, it might make sense to have a `kserverID` instead.