Page MenuHomePhabricator

[native][web] Add a context provider on native that exposes notifications session creator
ClosedPublic

Authored by tomek on Jan 17 2024, 7:59 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:40 PM
Unknown Object (File)
Sun, Oct 20, 2:35 PM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Sep 6 2024, 8:55 PM
Subscribers

Details

Summary

This makes it more convenient to use this function on both platforms.

Depends on D10662

Test Plan

Check if encrypted notifs work on iOS and web.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

tomek held this revision as a draft.
tomek published this revision for review.Jan 17 2024, 8:51 AM
tomek retitled this revision from [native][web] Add a context provider on web that exposes notifications session creator to [native][web] Add a context provider on native that exposes notifications session creator.Jan 17 2024, 9:04 AM
kamil added inline comments.
web/root.js
47 ↗(On Diff #35725)

the previous order was more readable I think - don't see any dependency why to force IdentityServiceContextProvider to be nested but leaving this up to you

This revision is now accepted and ready to land.Jan 18 2024, 9:50 AM

Reverse providers order

web/root.js
47 ↗(On Diff #35725)

Right, that makes sense