Page MenuHomePhabricator
Differential D10663

[native][web] Add a context provider on native that exposes notifications session creator
ClosedPublic
Actions

Authored by tomek on Jan 17 2024, 7:59 AM.
Tags
None
Referenced Files
F3388238: D10663.diff
Fri, Nov 29, 1:17 PM
Unknown Object (File)
Tue, Nov 26, 5:52 AM
Unknown Object (File)
Thu, Nov 7, 10:06 PM
Unknown Object (File)
Wed, Nov 6, 5:09 AM
Unknown Object (File)
Oct 22 2024, 4:41 PM
Unknown Object (File)
Oct 22 2024, 4:41 PM
Unknown Object (File)
Oct 22 2024, 4:41 PM
Unknown Object (File)
Oct 22 2024, 4:41 PM
View All 75 Files
Subscribers
ashoat

Details

Reviewers
varun
marcin
inka
kamil
Commits
rCOMMbf1ff1e5e8ff: [native][web] Add a context provider on native that exposes notifications…
Summary

This makes it more convenient to use this function on both platforms.

Depends on D10662

Test Plan

Check if encrypted notifs work on iOS and web.

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jan 17 2024, 7:59 AM
tomek held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2024, 7:59 AM
tomek edited the summary of this revision. (Show Details)Jan 17 2024, 8:00 AM
tomek added a parent revision: D10662: [web] Introduce deviceID parameter to initial notif message function.
tomek added a child revision: D10664: [native][web] Make identity client mandatory.Jan 17 2024, 8:03 AM
Harbormaster completed remote builds in B25836: Diff 35725.Jan 17 2024, 8:19 AM
tomek published this revision for review.Jan 17 2024, 8:51 AM
tomek retitled this revision from [native][web] Add a context provider on web that exposes notifications session creator to [native][web] Add a context provider on native that exposes notifications session creator.Jan 17 2024, 9:04 AM
kamil accepted this revision.Jan 18 2024, 9:50 AM
kamil added inline comments.
web/root.js
47 ↗(On Diff #35725)

the previous order was more readable I think - don't see any dependency why to force IdentityServiceContextProvider to be nested but leaving this up to you

This revision is now accepted and ready to land.Jan 18 2024, 9:50 AM
tomek updated this revision to Diff 35810.Jan 18 2024, 10:12 AM

Reverse providers order

web/root.js
47 ↗(On Diff #35725)

Right, that makes sense

Harbormaster completed remote builds in B25909: Diff 35810.Jan 18 2024, 10:32 AM
marcin accepted this revision.Jan 19 2024, 3:07 AM
tomek updated this revision to Diff 35873.Jan 19 2024, 6:20 AM

Rename

Harbormaster completed remote builds in B25951: Diff 35873.Jan 19 2024, 6:38 AM
Closed by commit rCOMMbf1ff1e5e8ff: [native][web] Add a context provider on native that exposes notifications… (authored by tomek). · Explain WhyJan 19 2024, 8:03 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMbf1ff1e5e8ff: [native][web] Add a context provider on native that exposes notifications….

Revision Contents
Changeset List

PathSize
lib/
shared/
20 lines
types/
10 lines
native/
account/
41 lines
111 lines
web/
account/
15 lines
6 lines

Diff 35810

View Options

lib/shared/notifications-session-creator-context.js

Loading...
View Options

lib/types/crypto-types.js

Loading...
View Options

native/account/account-hooks.js

Loading...
View Options

native/root.react.js

Loading...
View Options

web/account/account-hooks.js

Loading...
View Options

web/root.js

Loading...