Page MenuHomePhabricator
Differential D10664

[native][web] Make identity client mandatory
ClosedPublic
Actions

Authored by tomek on Jan 17 2024, 8:03 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 2, 1:40 PM
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:41 PM
Unknown Object (File)
Tue, Oct 22, 4:40 PM
Unknown Object (File)
Fri, Oct 18, 6:55 AM
Unknown Object (File)
Sep 6 2024, 8:55 PM
View All 60 Files
Subscribers
ashoat

Details

Reviewers
varun
inka
kamil
ashoat
Commits
rCOMMd5ef4a27085a: [native][web] Make identity client mandatory
Summary

Replace effect with memo and make the value mandatory which simplifies its usage.

Depends on D10663

Test Plan

Flow

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

tomek created this revision.Jan 17 2024, 8:03 AM
Herald added a subscriber: ashoat. · View Herald TranscriptJan 17 2024, 8:03 AM
tomek removed a reviewer: marcin.Jan 17 2024, 8:06 AM
tomek added a child revision: D10665: [lib] Improve error handling in connection handler.Jan 17 2024, 8:07 AM
Harbormaster completed remote builds in B25837: Diff 35726.Jan 17 2024, 8:21 AM
tomek requested review of this revision.Jan 17 2024, 8:21 AM
ashoat accepted this revision.Jan 17 2024, 8:24 AM
ashoat added inline comments.
native/identity-service/identity-service-context-provider.react.js
63–91 ↗(On Diff #35726)

Nit: this can be slightly simplified

This revision is now accepted and ready to land.Jan 17 2024, 8:24 AM
tomek updated this revision to Diff 35808.Jan 18 2024, 9:49 AM

Simplify

Harbormaster completed remote builds in B25907: Diff 35808.Jan 18 2024, 10:08 AM
tomek updated this revision to Diff 35874.Jan 19 2024, 6:22 AM

Rebase

Harbormaster completed remote builds in B25952: Diff 35874.Jan 19 2024, 6:40 AM
Closed by commit rCOMMd5ef4a27085a: [native][web] Make identity client mandatory (authored by tomek). · Explain WhyJan 19 2024, 8:03 AM
This revision was automatically updated to reflect the committed changes.
tomek added a commit: rCOMMd5ef4a27085a: [native][web] Make identity client mandatory.

Revision Contents
Changeset List

Diff 35874

View Options

lib/shared/identity-client-context.js

Loading...
View Options

native/identity-service/identity-service-context-provider.react.js

Loading...
View Options

web/grpc/identity-service-context-provider.react.js

Loading...