Differential D10767

[lib] refactor keyserver register in `keyserver-reducer` to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:29 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Sep 5, 5:26 AM

	Unknown Object (File)
	Wed, Sep 4, 7:43 AM

	Unknown Object (File)
	Sun, Sep 1, 11:54 PM

	Unknown Object (File)
	Fri, Aug 30, 6:34 PM

	Unknown Object (File)
	Aug 10 2024, 5:37 AM

	Unknown Object (File)
	Aug 9 2024, 9:24 PM

	Unknown Object (File)
	Aug 5 2024, 1:38 PM

	Unknown Object (File)
	Aug 5 2024, 1:38 PM

View All 33 Files

Subscribers

Details

Reviewers

Commits

rCOMMfe3c795750ce: [lib] refactor keyserver register in `keyserver-reducer` to ops

Summary

Convert logic to ops approach.

Creating separate diff because I am a bit confused - @inka is modifying the state instead of returning on purpose?

Test Plan

Register new user on native and make sure state is properly set

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 22 2024, 3:29 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:29 AM

kamil edited parent revisions, added: D10766: [lib] refactor processing updates and setting `urlPrefix` in `keyserver-reducer` to ops; removed: D10763: [lib] refactor state-sync actions in `keyserver-reducer` to ops.Jan 22 2024, 3:34 AM

kamil added a child revision: D10768: [lib] refactor updating connection status in `keyserver-reducer` to ops.

Harbormaster completed remote builds in B25994: Diff 35926.Jan 22 2024, 3:47 AM

kamil published this revision for review.Jan 22 2024, 6:35 AM

Creating separate diff because I am a bit confused - @inka is modifying the state instead of returning on purpose?

I must have missed that in D9820, it should be fine to return, since we don't do anything with the state later in the reducer.

Please add a test plan or explain why N/A

In D10767#310649, @inka wrote:

Creating separate diff because I am a bit confused - @inka is modifying the state instead of returning on purpose?

I must have missed that in D9820, it should be fine to return, since we don't do anything with the state later in the reducer.

Thank for response

Please add a test plan or explain why N/A

Updated

kamil edited the test plan for this revision. (Show Details)Jan 27 2024, 9:12 AM

kamil added a parent revision: D10763: [lib] refactor state-sync actions in `keyserver-reducer` to ops.

kamil edited the summary of this revision. (Show Details)

kamil removed a parent revision: D10763: [lib] refactor state-sync actions in `keyserver-reducer` to ops.

inka accepted this revision.Jan 29 2024, 1:46 AM

This revision is now accepted and ready to land.Jan 29 2024, 1:46 AM

Closed by commit rCOMMfe3c795750ce: [lib] refactor keyserver register in `keyserver-reducer` to ops (authored by kamil). · Explain WhyJan 31 2024, 8:23 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMfe3c795750ce: [lib] refactor keyserver register in `keyserver-reducer` to ops.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

14 lines

Diff 36394

lib/reducers/keyserver-reducer.js

Loading...