Page MenuHomePhabricator

[lib] refactor connection-related actions in `keyserver-reducer` to ops
ClosedPublic

Authored by kamil on Jan 22 2024, 3:37 AM.
Tags
None
Referenced Files
F2832331: D10771.id36399.diff
Sat, Sep 28, 3:55 AM
F2832330: D10771.id35945.diff
Sat, Sep 28, 3:55 AM
F2832329: D10771.id35931.diff
Sat, Sep 28, 3:55 AM
F2832278: D10771.id.diff
Sat, Sep 28, 3:54 AM
F2832264: D10771.diff
Sat, Sep 28, 3:54 AM
Unknown Object (File)
Wed, Sep 4, 6:34 AM
Unknown Object (File)
Aug 5 2024, 1:38 PM
Unknown Object (File)
Aug 5 2024, 1:38 PM
Subscribers

Details

Summary

Convert logic to ops approach.

Depends on D10770

Test Plan

This is not that easy to test, and this sie basically copy-pasting approach from rest of the stack so this time just carefully reading the code.

EDIT: tested by dispatching following from redux dev-tools:

{
  type: 'SET_LATE_RESPONSE',
  payload: { messageID: '256|5', isLate: true, keyserverID: '256' }
}
{
  type: 'UPDATE_DISCONNECTED_BAR',
  payload: { visible: 'true', keyserverID: '256' }
}
{
  type: 'SET_CONNECTION_ISSUE',
  payload: { connectionIssue: null, keyserverID: '256' },
}

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.

Is there a reason this diff is a draft? (Maybe test plan)

kamil published this revision for review.Jan 27 2024, 9:31 AM
kamil edited the test plan for this revision. (Show Details)

Is there a reason this diff is a draft? (Maybe test plan)

yes, I wanted to check with @inka what is the best way to test it before publishing

This revision is now accepted and ready to land.Jan 30 2024, 1:47 AM