Details
Details
Calling those methods from JS and making sure it works.
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
native/cpp/CommonCpp/DatabaseManagers/SQLiteQueryExecutor.cpp | ||
---|---|---|
1341 ↗ | (On Diff #35951) | Wondering if method taking a vector of id's to remove multiple keyservers at once wouldn't be more practical. Actually this is what we do in the rest of the code. |
Comment Actions
Before landing I think you should:
- Refactor removeKeyserver to removeKeyservers that takes std::vector<std::string> ids instead of std::string id. It is more practical and matches convention.
- Implement some unit tests for the KeyserverStore in the same manner that you did for other stores that have already migrated to the database on web.