Paths

Table of Contentst

-
lib/reducers/
-
reducers/
-
keyserver-reducer.js

Differential D10763

[lib] refactor state-sync actions in `keyserver-reducer` to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:04 AM.

Details

Reviewers

inka

Commits

rCOMMa6da6f68e41b: [lib] refactor state-sync actions in `keyserver-reducer` to ops

Summary

Convert logic to ops approach.

Depends on D10761

Test Plan

Test for fullStateSyncActionType:

Make sessionInitializationResult.sessionContinued in keyserver's socket to always return true
Make sure updatesCurrentAsOf is properly set after ops

Test for incrementalStateSyncActionType:

Close and open app
Make sure updatesCurrentAsOf is properly set after ops

Tested on native

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kamil created this revision.Jan 22 2024, 3:04 AM

kamil held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:04 AM

kamil added a child revision: D10766: [lib] refactor processing updates and setting `urlPrefix` in `keyserver-reducer` to ops.Jan 22 2024, 3:28 AM

kamil added a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.

kamil added a child revision: D10768: [lib] refactor updating connection status in `keyserver-reducer` to ops.

kamil removed a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.Jan 22 2024, 3:34 AM

kamil removed a child revision: D10768: [lib] refactor updating connection status in `keyserver-reducer` to ops.

Harbormaster completed remote builds in B25986: Diff 35918.Jan 22 2024, 3:42 AM

kamil published this revision for review.Jan 22 2024, 6:34 AM

inka accepted this revision.Jan 22 2024, 9:27 AM

This revision is now accepted and ready to land.Jan 22 2024, 9:27 AM

kamil added a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.Jan 27 2024, 9:12 AM

kamil removed a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.

Closed by commit rCOMMa6da6f68e41b: [lib] refactor state-sync actions in `keyserver-reducer` to ops (authored by kamil). · Explain WhyJan 31 2024, 8:23 AM

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMMa6da6f68e41b: [lib] refactor state-sync actions in `keyserver-reducer` to ops.

Revision Contents
Changeset List

Path

Size

lib/

reducers/

keyserver-reducer.js

30 lines

Diff 36393

View Options

lib/reducers/keyserver-reducer.js

Show All 23 Lines
import { reduceThreadInfos } from './thread-reducer.js';		import { reduceThreadInfos } from './thread-reducer.js';
import { reduceCurrentUserInfo, reduceUserInfos } from './user-reducer.js';		import { reduceCurrentUserInfo, reduceUserInfos } from './user-reducer.js';
import { addKeyserverActionType } from '../actions/keyserver-actions.js';		import { addKeyserverActionType } from '../actions/keyserver-actions.js';
import { siweAuthActionTypes } from '../actions/siwe-actions.js';		import { siweAuthActionTypes } from '../actions/siwe-actions.js';
import {		import {
keyserverRegisterActionTypes,		keyserverRegisterActionTypes,
logInActionTypes,		logInActionTypes,
} from '../actions/user-actions.js';		} from '../actions/user-actions.js';
		import {
		keyserverStoreOpsHandlers,
		type ReplaceKeyserverOperation,
		} from '../ops/keyserver-store-ops.js';
import { isStaff } from '../shared/staff-utils.js';		import { isStaff } from '../shared/staff-utils.js';
import type { BaseNavInfo } from '../types/nav-types.js';		import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState, BaseAction } from '../types/redux-types.js';		import type { BaseAppState, BaseAction } from '../types/redux-types.js';
import {		import {
fullStateSyncActionType,		fullStateSyncActionType,
incrementalStateSyncActionType,		incrementalStateSyncActionType,
} from '../types/socket-types.js';		} from '../types/socket-types.js';
import type { StoreOperations } from '../types/store-ops-types.js';		import type { StoreOperations } from '../types/store-ops-types.js';
▲ Show 20 Lines • Show All 42 Lines • ▼ Show 20 Lines	): { state: T, storeOperations: StoreOperations } {
if (		if (
action.type !== incrementalStateSyncActionType &&		action.type !== incrementalStateSyncActionType &&
action.type !== fullStateSyncActionType &&		action.type !== fullStateSyncActionType &&
action.type !== keyserverRegisterActionTypes.success &&		action.type !== keyserverRegisterActionTypes.success &&
action.type !== logInActionTypes.success &&		action.type !== logInActionTypes.success &&
action.type !== siweAuthActionTypes.success &&		action.type !== siweAuthActionTypes.success &&
action.type !== addKeyserverActionType		action.type !== addKeyserverActionType
) {		) {
		const replaceOperations: ReplaceKeyserverOperation[] = [];
for (const keyserverID in keyserverStore.keyserverInfos) {		for (const keyserverID in keyserverStore.keyserverInfos) {
if (		if (
keyserverStore.keyserverInfos[keyserverID].connection.status ===		keyserverStore.keyserverInfos[keyserverID].connection.status ===
'connected'		'connected'
) {		) {
continue;		continue;
}		}
if (		if (
messageStore.currentAsOf[keyserverID] !==		messageStore.currentAsOf[keyserverID] !==
state.messageStore.currentAsOf[keyserverID]		state.messageStore.currentAsOf[keyserverID]
) {		) {
messageStore = {		messageStore = {
...messageStore,		...messageStore,
currentAsOf: {		currentAsOf: {
...messageStore.currentAsOf,		...messageStore.currentAsOf,
[keyserverID]: state.messageStore.currentAsOf[keyserverID],		[keyserverID]: state.messageStore.currentAsOf[keyserverID],
},		},
};		};
}		}
if (		if (
state.keyserverStore.keyserverInfos[keyserverID] &&		state.keyserverStore.keyserverInfos[keyserverID] &&
keyserverStore.keyserverInfos[keyserverID].updatesCurrentAsOf !==		keyserverStore.keyserverInfos[keyserverID].updatesCurrentAsOf !==
state.keyserverStore.keyserverInfos[keyserverID].updatesCurrentAsOf		state.keyserverStore.keyserverInfos[keyserverID].updatesCurrentAsOf
) {		) {
const keyserverInfos = { ...keyserverStore.keyserverInfos };		replaceOperations.push({
keyserverInfos[keyserverID] = {		type: 'replace_keyserver',
...keyserverInfos[keyserverID],		payload: {
		id: keyserverID,
		keyserverInfo: {
		...keyserverStore.keyserverInfos[keyserverID],
updatesCurrentAsOf:		updatesCurrentAsOf:
state.keyserverStore.keyserverInfos[keyserverID].updatesCurrentAsOf,		state.keyserverStore.keyserverInfos[keyserverID]
};		.updatesCurrentAsOf,
keyserverStore = { ...keyserverStore, keyserverInfos };		},
		},
		});
}		}
}		}
		if (replaceOperations.length > 0) {
		keyserverStore = {
		...keyserverStore,
		keyserverInfos: keyserverStoreOpsHandlers.processStoreOperations(
		keyserverStore.keyserverInfos,
		replaceOperations,
		),
		};
		}
}		}

const { draftStore, draftStoreOperations } = reduceDraftStore(		const { draftStore, draftStoreOperations } = reduceDraftStore(
state.draftStore,		state.draftStore,
action,		action,
);		);

const { reportStore, reportStoreOperations } = reduceReportStore(		const { reportStore, reportStoreOperations } = reduceReportStore(
▲ Show 20 Lines • Show All 63 Lines • Show Last 20 Lines

[lib] refactor state-sync actions in `keyserver-reducer` to opsClosedPublicActions