Page MenuHomePhabricator
Differential D10763

[lib] refactor state-sync actions in `keyserver-reducer` to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 3:04 AM.
Tags
None
Referenced Files
F2152017: D10763.diff
Sun, Jun 30, 2:03 PM
Unknown Object (File)
Wed, Jun 26, 11:28 AM
Unknown Object (File)
Mon, Jun 24, 1:25 PM
Unknown Object (File)
Thu, Jun 13, 4:58 AM
Unknown Object (File)
Thu, Jun 6, 2:24 PM
Unknown Object (File)
Thu, Jun 6, 8:18 AM
Unknown Object (File)
Sat, Jun 1, 2:06 PM
Unknown Object (File)
May 23 2024, 10:14 AM
View All 22 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMMa6da6f68e41b: [lib] refactor state-sync actions in `keyserver-reducer` to ops
Summary

Convert logic to ops approach.

Depends on D10761

Test Plan

Test for fullStateSyncActionType:

  1. Make sessionInitializationResult.sessionContinued in keyserver's socket to always return true
  2. Make sure updatesCurrentAsOf is properly set after ops

Test for incrementalStateSyncActionType:

  1. Close and open app
  2. Make sure updatesCurrentAsOf is properly set after ops

Tested on native

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Jan 22 2024, 3:04 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 3:04 AM
kamil added a child revision: D10766: [lib] refactor processing updates and setting `urlPrefix` in `keyserver-reducer` to ops.Jan 22 2024, 3:28 AM
kamil added a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.
kamil added a child revision: D10768: [lib] refactor updating connection status in `keyserver-reducer` to ops.
kamil removed a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.Jan 22 2024, 3:34 AM
kamil removed a child revision: D10768: [lib] refactor updating connection status in `keyserver-reducer` to ops.
Harbormaster completed remote builds in B25986: Diff 35918.Jan 22 2024, 3:42 AM
kamil published this revision for review.Jan 22 2024, 6:34 AM
inka accepted this revision.Jan 22 2024, 9:27 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:27 AM
kamil added a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.Jan 27 2024, 9:12 AM
kamil removed a child revision: D10767: [lib] refactor keyserver register in `keyserver-reducer` to ops.
Closed by commit rCOMMa6da6f68e41b: [lib] refactor state-sync actions in `keyserver-reducer` to ops (authored by kamil). · Explain WhyJan 31 2024, 8:23 AM
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMa6da6f68e41b: [lib] refactor state-sync actions in `keyserver-reducer` to ops.

Revision Contents
Changeset List

PathSize
lib/
reducers/
30 lines

Diff 35918

View Options

lib/reducers/keyserver-reducer.js

Loading...