Page MenuHomePhabricator
Differential D10757

[lib] refactor adding keyserver to ops
ClosedPublic
Actions

Authored by kamil on Jan 22 2024, 2:53 AM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 18, 1:39 PM
Unknown Object (File)
Fri, Apr 18, 1:15 PM
Unknown Object (File)
Fri, Apr 18, 9:48 AM
Unknown Object (File)
Thu, Apr 17, 10:08 AM
Unknown Object (File)
Wed, Apr 9, 12:42 AM
Unknown Object (File)
Mon, Apr 7, 1:02 PM
Unknown Object (File)
Sat, Mar 29, 9:46 PM
Unknown Object (File)
Mar 8 2025, 10:34 PM
View All 67 Files
Subscribers
ashoat
tomek

Details

Reviewers
inka
Commits
rCOMMabdd92dbbe72: [lib] refactor adding keyserver to ops
Summary

Convert logic to ops approach.

Depends on D10755

Test Plan
  1. Remove validation while adding keyserver
  2. Add keyserver

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil created this revision.Jan 22 2024, 2:53 AM
kamil held this revision as a draft.
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 22 2024, 2:53 AM
kamil added a child revision: D10758: [lib] refactor removing keyserver to ops.Jan 22 2024, 2:54 AM
Harbormaster failed remote builds in B25980: Diff 35912!Jan 22 2024, 3:19 AM
kamil published this revision for review.Jan 22 2024, 6:32 AM
inka accepted this revision.Jan 22 2024, 9:05 AM
This revision is now accepted and ready to land.Jan 22 2024, 9:05 AM
This revision was landed with ongoing or failed builds.Jan 31 2024, 8:23 AM
Closed by commit rCOMMabdd92dbbe72: [lib] refactor adding keyserver to ops (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMMabdd92dbbe72: [lib] refactor adding keyserver to ops.

Revision Contents
Changeset List

PathSize
lib/
reducers/
21 lines

Diff 36388

View Options

lib/reducers/keyserver-reducer.js

Show All 16 LinesIntegrityStore::IntegrityStore(
std::shared_ptr<facebook::react::CallInvoker> jsInvoker) std::shared_ptr<facebook::react::CallInvoker> jsInvoker)
: BaseDataStore(jsInvoker) { : BaseDataStore(jsInvoker) {
} }
jsi::Array IntegrityStore::parseDBDataStore( jsi::Array IntegrityStore::parseDBDataStore(
jsi::Runtime &rt, jsi::Runtime &rt,
std::shared_ptr<std::vector<IntegrityThreadHash>> std::shared_ptr<std::vector<IntegrityThreadHash>>
integrityThreadHashesVectorPtr) const { integrityThreadHashesVectorPtr) const {
jsi::Array jsiIntegrityThreadHashes = jsi::Array(rt, 0); size_t numIntegrityThreadHashes = integrityThreadHashesVectorPtr->size();
jsi::Array jsiIntegrityThreadHashes =
jsi::Array(rt, numIntegrityThreadHashes);
size_t writeIdx = 0;
for (const IntegrityThreadHash &integrityThreadHash :
*integrityThreadHashesVectorPtr) {
jsi::Object jsiIntegrityThreadHash = jsi::Object(rt);
jsiIntegrityThreadHash.setProperty(rt, "id", integrityThreadHash.id);
jsiIntegrityThreadHash.setProperty(
rt, "threadHash", integrityThreadHash.thread_hash);
jsiIntegrityThreadHashes.setValueAtIndex(
rt, writeIdx++, jsiIntegrityThreadHash);
}
return jsiIntegrityThreadHashes; return jsiIntegrityThreadHashes;
} }
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> std::vector<std::unique_ptr<IntegrityStoreOperationBase>>
IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations) IntegrityStore::createOperations(jsi::Runtime &rt, const jsi::Array &operations)
const { const {
std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps; std::vector<std::unique_ptr<IntegrityStoreOperationBase>> integrityStoreOps;
▲ Show 20 Lines • Show All 58 Lines • Show Last 20 Lines