Page MenuHomePhabricator

[SQLite] add `keyservers` table for `KeyserverStore` data
ClosedPublic

Authored by kamil on Jan 22 2024, 3:43 AM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jun 27, 1:23 AM
Unknown Object (File)
Mon, Jun 24, 6:49 PM
Unknown Object (File)
Sat, Jun 1, 9:00 AM
Unknown Object (File)
May 23 2024, 7:36 AM
Unknown Object (File)
May 21 2024, 1:59 PM
Unknown Object (File)
May 21 2024, 1:59 PM
Unknown Object (File)
May 21 2024, 1:19 PM
Unknown Object (File)
Mar 6 2024, 6:21 PM
Subscribers

Details

Summary

Table to store data from KeyserverStore in SQLite.

Based on types defined in D10755.

Making table key-value (value is keyserver info in JSON) saves some implementation time and makes code more complicated. I discussed this with both @inka and @tomek and this should be enough - there is no need to make more columns (we can always migrate when there is any need).

Test Plan
  1. Test migration.
  2. Logout and test creating database from scratch.

Test on both web (it's visible in worker's logs) and native.

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

kamil held this revision as a draft.
kamil published this revision for review.Jan 22 2024, 6:37 AM
kamil edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Jan 22 2024, 9:45 AM

cc @marcin, who is working on refactoring our SQLite layer to no longer have sqlite_orm

cc @marcin, who is working on refactoring our SQLite layer to no longer have sqlite_orm

This particular diff doesn't affect my work since ORM is not used here, but thanks for catching this!