Details

Reviewers

varun
bartek

Commits

rCOMMe4cdbf3fee9c: [shared] [identity] [2/n] Add identity_search_messages to shared and use in…

Summary

This introduces identity_search_messages into shared for usage by identity's prefix search websocket services and commtest (in later diffs).

Depends on D10802

Test Plan

cargo fmt and build. Successfully running identity service

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 24 2024, 9:24 PM

will held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 24 2024, 9:24 PM

will published this revision for review.Jan 24 2024, 9:25 PM

Harbormaster completed remote builds in B26128: Diff 36101.Jan 24 2024, 9:43 PM

make connection initialization messages pub

Harbormaster completed remote builds in B26129: Diff 36103.Jan 24 2024, 10:40 PM

will planned changes to this revision.Jan 26 2024, 3:44 PM

will requested review of this revision.Jan 26 2024, 10:48 PM

will retitled this revision from Add identity_search_messages to shared and use in identity to [services] [2/n] Add identity_search_messages to shared and use in identity.Jan 26 2024, 10:51 PM

will added a child revision: D10847: [identity] [3/n] move websocket response functions to send.rs.

varun accepted this revision.Jan 30 2024, 3:35 AM

varun added inline comments.

shared/identity_search_messages/src/messages/auth_messages.rs
1–2 ↗	(On Diff #36103)	This doc comment seemingly doesn't match the actual contents of the file. Guessing there's more to come here but would be good to have the comment accurately reflect what's in here

This revision is now accepted and ready to land.Jan 30 2024, 3:35 AM

Update doc comments

Harbormaster completed remote builds in B26298: Diff 36345.Jan 30 2024, 5:36 AM

will retitled this revision from [services] [2/n] Add identity_search_messages to shared and use in identity to [shared] [identity] [2/n] Add identity_search_messages to shared and use in identity.Jan 30 2024, 7:06 PM

bartek accepted this revision.Jan 31 2024, 9:58 AM

Add ConnectionInitializationResponse to Messages

Harbormaster completed remote builds in B26359: Diff 36430.Jan 31 2024, 7:08 PM

Closed by commit rCOMMe4cdbf3fee9c: [shared] [identity] [2/n] Add identity_search_messages to shared and use in…. · Explain WhyJan 31 2024, 7:10 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMMe4cdbf3fee9c: [shared] [identity] [2/n] Add identity_search_messages to shared and use in….

[shared] [identity] [2/n] Add identity_search_messages to shared and use in identity
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36436

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/src/websockets/auth.rs

shared/identity_search_messages/.gitignore

shared/identity_search_messages/Cargo.lock

shared/identity_search_messages/Cargo.toml

shared/identity_search_messages/src/lib.rs

shared/identity_search_messages/src/messages/auth_messages.rs

shared/identity_search_messages/src/messages/mod.rs

[shared] [identity] [2/n] Add identity_search_messages to shared and use in identityClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36436

services/identity/Cargo.lock

services/identity/Cargo.toml

services/identity/src/websockets/auth.rs

shared/identity_search_messages/.gitignore

shared/identity_search_messages/Cargo.lock

shared/identity_search_messages/Cargo.toml

shared/identity_search_messages/src/lib.rs

shared/identity_search_messages/src/messages/auth_messages.rs

shared/identity_search_messages/src/messages/mod.rs

[shared] [identity] [2/n] Add identity_search_messages to shared and use in identity
ClosedPublic
Actions

Revision Contents
Changeset List