[shared] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate
ClosedPublic
Actions

Authored by will on Jan 24 2024, 12:48 PM.

Details

Reviewers

varun
bartek
kamil

Commits

rCOMM739d8ebb85c8: [shared] [1/n] Move generic websocket messages in tunnelbroker_messages to own…

Summary

This moves ConnectionInitializationResponse, ConnectionInitializationStatus, and Heartbeat from tunnelbroker_messages into websocket_messages.

This enables usage in a planned identity_search_messages crate to avoid duplication.

Test Plan

cargo fmt and build each affected crate

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 24 2024, 12:48 PM

will held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 24 2024, 12:48 PM

will added inline comments.Jan 24 2024, 12:53 PM

shared/tunnelbroker_messages/src/messages/mod.rs
17 ↗	(On Diff #36099)	What makes this move possibly confusing is the existence of the `ConnectionInitializationMessage` in tunnelbroker_messages that corresponds to `ConnectionInitializationResponse` and `ConnectionInitializationStatus`. `ConnectionInitializationResponse` and `ConnectionInitializationStatus` will be used in conjunction with the planned `identity_search_messages` with `AuthMessage` instead of `ConnectionInitializationMessage`.

Harbormaster completed remote builds in B26126: Diff 36099.Jan 24 2024, 1:14 PM

will published this revision for review.Jan 24 2024, 1:18 PM

will added a child revision: D10804: [shared] [identity] [2/n] Add identity_search_messages to shared and use in identity.Jan 24 2024, 1:24 PM

will planned changes to this revision.Jan 26 2024, 7:43 AM

will requested review of this revision.Jan 26 2024, 2:48 PM

will retitled this revision from Move generic websocket messages in tunnelbroker_messages to own crate to [services] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate.Jan 26 2024, 2:51 PM

Who wrote the Tunnelbroker stuff that you're moving? Would be good to have them on the review as well

In D10802#312459, @ashoat wrote:

Who wrote the Tunnelbroker stuff that you're moving? Would be good to have them on the review as well

That would be Kamil. Just added

Looks good to me, but I want to make sure @kamil is also aware of this change

will retitled this revision from [services] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate to [identity] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate.Jan 30 2024, 11:05 AM

will retitled this revision from [identity] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate to [shared] [1/n] Move generic websocket messages in tunnelbroker_messages to own crate.

kamil accepted this revision.Jan 31 2024, 2:00 AM

This revision is now accepted and ready to land.Jan 31 2024, 2:00 AM

Closed by commit rCOMM739d8ebb85c8: [shared] [1/n] Move generic websocket messages in tunnelbroker_messages to own… (authored by will). · Explain WhyJan 31 2024, 11:10 AM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM739d8ebb85c8: [shared] [1/n] Move generic websocket messages in tunnelbroker_messages to own….

kamil mentioned this in D10915: [services] update `Cargo.lock` in commtest.Feb 1 2024, 11:53 AM

kamil mentioned this in rCOMMe864a2978dd6: [services] update `Cargo.lock` in commtest.Feb 1 2024, 12:14 PM