[identity] [8/n] Implement Heartbeats on identity search ws server
ClosedPublic
Actions

Authored by will on Jan 29 2024, 4:13 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM563b6202403e: [identity] [8/n] Implement Heartbeats on identity search ws server

Summary

This implemented heartbeats, setting a timing out after 3 seconds and sending a heartbeat every 3 seconds.

Depends on D10874

Test Plan

Tested on local dev. Without sending a heartbeat or search query at least every 3 seconds, the websocket connection will automatically close. The client also receives a heartbeat every 3 seconds as well.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 29 2024, 4:13 PM

will held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 4:13 PM

will retitled this revision from [services] Implement Heartbeats on identity search ws server to [services] [8/n] Implement Heartbeats on identity search ws server.Jan 29 2024, 4:17 PM

will edited the summary of this revision. (Show Details)

will edited the test plan for this revision. (Show Details)

will edited the summary of this revision. (Show Details)

will added a parent revision: D10874: [identity] [7/n] Replaces sending messages with `send_message` function.

Harbormaster completed remote builds in B26292: Diff 36332.Jan 29 2024, 4:32 PM

will published this revision for review.Jan 29 2024, 6:50 PM

will retitled this revision from [services] [8/n] Implement Heartbeats on identity search ws server to [identity] [8/n] Implement Heartbeats on identity search ws server.Jan 30 2024, 11:07 AM

Tested on local dev. Without sending a heartbeat or search query at least every 3 seconds, the
websocket connection will automatically close. The client also receives

Looks like this test plan message has been cut

will added a child revision: D10878: [lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of lib tunnelbroker into shared websocket folder.Jan 31 2024, 8:44 AM

will edited the test plan for this revision. (Show Details)

bartek accepted this revision.Jan 31 2024, 12:14 PM

This revision is now accepted and ready to land.Jan 31 2024, 12:14 PM

rebase

Harbormaster completed remote builds in B26382: Diff 36477.Jan 31 2024, 2:25 PM

Closed by commit rCOMM563b6202403e: [identity] [8/n] Implement Heartbeats on identity search ws server (authored by will). · Explain WhyJan 31 2024, 2:52 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM563b6202403e: [identity] [8/n] Implement Heartbeats on identity search ws server.

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

constants.rs

4 lines

websockets/

mod.rs

136 lines

Diff 36491

View Options

services/identity/src/constants.rs

Show First 20 Lines • Show All 72 Lines • ▼ Show 20 Lines	"dependencies": {
"ethers": "^6.11.1",		"ethers": "^6.11.1",
"expo": "47.0.14",		"expo": "47.0.14",
"expo-application": "^5.1.1",		"expo-application": "^5.1.1",
"expo-barcode-scanner": "~12.1.0",		"expo-barcode-scanner": "~12.1.0",
"expo-dev-client": "~2.0.1",		"expo-dev-client": "~2.0.1",
"expo-file-system": "~15.1.1",		"expo-file-system": "~15.1.1",
"expo-font": "~11.0.1",		"expo-font": "~11.0.1",
"expo-haptics": "~12.0.1",		"expo-haptics": "~12.0.1",
"expo-image": "^1.2.2",		"expo-image": "1.2.3",
"expo-image-manipulator": "~11.0.0",		"expo-image-manipulator": "~11.0.0",
"expo-image-picker": "~14.0.2",		"expo-image-picker": "~14.0.2",
"expo-media-library": "~15.0.0",		"expo-media-library": "~15.0.0",
"expo-secure-store": "~12.0.0",		"expo-secure-store": "~12.0.0",
"expo-splash-screen": "~0.17.4",		"expo-splash-screen": "~0.17.4",
"find-root": "^1.1.0",		"find-root": "^1.1.0",
"invariant": "^2.2.4",		"invariant": "^2.2.4",
"lib": "0.0.1",		"lib": "0.0.1",
"lodash": "^4.17.21",		"lodash": "^4.17.21",
"lottie-react-native": "^5.1.4",		"lottie-react-native": "^5.1.4",
"md5": "^2.2.1",		"md5": "^2.2.1",
"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",		"olm": "git+https://github.com/CommE2E/olm.git#v0.2.1",
"react": "18.1.0",		"react": "18.1.0",
"react-native": "0.70.9",		"react-native": "0.70.9",
"react-native-camera": "^3.31.0",		"react-native-camera": "^3.31.0",
"react-native-device-info": "^10.3.0",		"react-native-device-info": "^10.3.0",
"react-native-ffmpeg": "^0.4.4",		"react-native-ffmpeg": "^0.5.2",
"react-native-figma-squircle": "^0.1.2",		"react-native-figma-squircle": "^0.1.2",
"react-native-floating-action": "^1.22.0",		"react-native-floating-action": "^1.22.0",
"react-native-fs": "^2.20.0",		"react-native-fs": "^2.20.0",
"react-native-gesture-handler": "^2.8.0",		"react-native-gesture-handler": "^2.8.0",
"react-native-in-app-message": "^1.0.2",		"react-native-in-app-message": "^1.0.2",
"react-native-keyboard-input": "6.0.1",		"react-native-keyboard-input": "6.0.1",
"react-native-keychain": "^8.0.0",		"react-native-keychain": "^8.0.0",
"react-native-orientation-locker": "^1.5.0",		"react-native-orientation-locker": "^1.5.0",
Show All 29 Lines