[identity] [8/n] Implement Heartbeats on identity search ws server
ClosedPublic
Actions

Authored by will on Jan 29 2024, 4:13 PM.

Details

Reviewers

varun
bartek

Commits

rCOMM563b6202403e: [identity] [8/n] Implement Heartbeats on identity search ws server

Summary

This implemented heartbeats, setting a timing out after 3 seconds and sending a heartbeat every 3 seconds.

Depends on D10874

Test Plan

Tested on local dev. Without sending a heartbeat or search query at least every 3 seconds, the websocket connection will automatically close. The client also receives a heartbeat every 3 seconds as well.

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 29 2024, 4:13 PM

will held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 4:13 PM

will retitled this revision from [services] Implement Heartbeats on identity search ws server to [services] [8/n] Implement Heartbeats on identity search ws server.Jan 29 2024, 4:17 PM

will edited the summary of this revision. (Show Details)

will edited the test plan for this revision. (Show Details)

will edited the summary of this revision. (Show Details)

will added a parent revision: D10874: [identity] [7/n] Replaces sending messages with `send_message` function.

Harbormaster completed remote builds in B26292: Diff 36332.Jan 29 2024, 4:32 PM

will published this revision for review.Jan 29 2024, 6:50 PM

will retitled this revision from [services] [8/n] Implement Heartbeats on identity search ws server to [identity] [8/n] Implement Heartbeats on identity search ws server.Jan 30 2024, 11:07 AM

Tested on local dev. Without sending a heartbeat or search query at least every 3 seconds, the
websocket connection will automatically close. The client also receives

Looks like this test plan message has been cut

will added a child revision: D10878: [lib] [9/n] Move ConnectionInitializationResponse and Heartbeat types out of lib tunnelbroker into shared websocket folder.Jan 31 2024, 8:44 AM

will edited the test plan for this revision. (Show Details)

bartek accepted this revision.Jan 31 2024, 12:14 PM

This revision is now accepted and ready to land.Jan 31 2024, 12:14 PM

rebase

Harbormaster completed remote builds in B26382: Diff 36477.Jan 31 2024, 2:25 PM

Closed by commit rCOMM563b6202403e: [identity] [8/n] Implement Heartbeats on identity search ws server (authored by will). · Explain WhyJan 31 2024, 2:52 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM563b6202403e: [identity] [8/n] Implement Heartbeats on identity search ws server.