Page MenuHomePhabricator

[identity] [3/n] move websocket response functions to send.rs
ClosedPublic

Authored by will on Jan 26 2024, 12:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Jul 4, 2:08 AM
Unknown Object (File)
Wed, Jul 3, 8:49 PM
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:38 AM
Unknown Object (File)
Mon, Jul 1, 11:37 AM
Unknown Object (File)
Mon, Jul 1, 11:37 AM
Unknown Object (File)
Fri, Jun 28, 1:16 AM
Unknown Object (File)
Thu, Jun 27, 9:27 PM
Subscribers

Details

Summary

This moves websocket response functions to send.rs for organization purposes

Depends on D10804

Test Plan

cargo run server runs the websocket server successfully

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will held this revision as a draft.
will published this revision for review.Jan 26 2024, 2:49 PM
will retitled this revision from [services] move websocket response functions to send.rs to [services] [3/n] move websocket response functions to send.rs.Jan 26 2024, 2:51 PM
will edited the summary of this revision. (Show Details)
will retitled this revision from [services] [3/n] move websocket response functions to send.rs to [identity] [3/n] move websocket response functions to send.rs.Jan 30 2024, 11:06 AM
bartek added inline comments.
services/identity/src/websockets/send.rs
18 ↗(On Diff #36195)

And here?

40 ↗(On Diff #36195)

can the type from L13 be used here?

This revision is now accepted and ready to land.Jan 31 2024, 2:02 AM
will marked an inline comment as done.Jan 31 2024, 2:23 PM
will added inline comments.
services/identity/src/websockets/send.rs
40 ↗(On Diff #36195)

Yep. Missed this comment when landing. Added to my diff stack:
https://phab.comm.dev/D10903