Details

Reviewers

varun
bartek

Commits

rCOMM148f33d88d63: [identity] [3/n] move websocket response functions to send.rs

Summary

This moves websocket response functions to send.rs for organization purposes

Depends on D10804

Test Plan

cargo run server runs the websocket server successfully

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

will created this revision.Jan 26 2024, 8:58 PM

will held this revision as a draft.

Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 26 2024, 8:58 PM

Harbormaster completed remote builds in B26206: Diff 36195.Jan 26 2024, 9:17 PM

will published this revision for review.Jan 26 2024, 10:49 PM

will retitled this revision from [services] move websocket response functions to send.rs to [services] [3/n] move websocket response functions to send.rs.Jan 26 2024, 10:51 PM

will edited the summary of this revision. (Show Details)

will added a parent revision: D10804: [shared] [identity] [2/n] Add identity_search_messages to shared and use in identity.

will added a child revision: D10848: [identity] [4/n] Return ConnectionInitializationResponse on identity search auth.

will mentioned this in D10874: [identity] [7/n] Replaces sending messages with `send_message` function.Jan 29 2024, 10:31 PM

will added a child revision: D10874: [identity] [7/n] Replaces sending messages with `send_message` function.Jan 29 2024, 10:32 PM

will retitled this revision from [services] [3/n] move websocket response functions to send.rs to [identity] [3/n] move websocket response functions to send.rs.Jan 30 2024, 7:06 PM

bartek accepted this revision.Jan 31 2024, 10:02 AM

bartek added inline comments.

services/identity/src/websockets/send.rs
18 ↗	(On Diff #36195)	And here?
40 ↗	(On Diff #36195)	can the type from L13 be used here?

This revision is now accepted and ready to land.Jan 31 2024, 10:02 AM

Closed by commit rCOMM148f33d88d63: [identity] [3/n] move websocket response functions to send.rs. · Explain WhyJan 31 2024, 7:10 PM

This revision was automatically updated to reflect the committed changes.

will added a commit: rCOMM148f33d88d63: [identity] [3/n] move websocket response functions to send.rs.

will marked an inline comment as done.Jan 31 2024, 10:23 PM

will added inline comments.

services/identity/src/websockets/send.rs
40 ↗	(On Diff #36195)	Yep. Missed this comment when landing. Added to my diff stack: https://phab.comm.dev/D10903

[identity] [3/n] move websocket response functions to send.rs
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 36437

services/identity/src/websockets/mod.rs

services/identity/src/websockets/send.rs

[identity] [3/n] move websocket response functions to send.rsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 36437

services/identity/src/websockets/mod.rs

services/identity/src/websockets/send.rs

[identity] [3/n] move websocket response functions to send.rs
ClosedPublic
Actions

Revision Contents
Changeset List