Page MenuHomePhabricator
Differential D10874

[identity] [7/n] Replaces sending messages with `send_message` function
ClosedPublic
Actions

Authored by will on Jan 29 2024, 2:31 PM.
Tags
None
Referenced Files
F3584346: D10874.id.diff
Sun, Dec 29, 4:36 PM
F3582704: D10874.diff
Sun, Dec 29, 12:44 PM
Unknown Object (File)
Thu, Dec 26, 7:08 PM
Unknown Object (File)
Thu, Dec 26, 7:08 PM
Unknown Object (File)
Mon, Dec 16, 7:18 AM
Unknown Object (File)
Nov 30 2024, 6:25 AM
Unknown Object (File)
Nov 28 2024, 11:32 PM
Unknown Object (File)
Nov 27 2024, 2:25 AM
View All 63 Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMcf573294103b: [identity] [7/n] Replaces sending messages with `send_message` function
Summary

This utilizes the send_message function introduced in D10847 to reduce code duplication with sending messages through SplitSink

Depends on D10847

Test Plan

tested locally

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

will created this revision.Jan 29 2024, 2:31 PM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptJan 29 2024, 2:31 PM
will edited the summary of this revision. (Show Details)Jan 29 2024, 2:32 PM
will added a parent revision: D10847: [identity] [3/n] move websocket response functions to send.rs.
Harbormaster completed remote builds in B26284: Diff 36317.Jan 29 2024, 2:49 PM
will requested review of this revision.Jan 29 2024, 2:49 PM
will retitled this revision from [services] Replaces sending messages with `send_message` function to [services] [7/n] Replaces sending messages with `send_message` function.Jan 29 2024, 3:21 PM
will added a child revision: D10875: [identity] [8/n] Implement Heartbeats on identity search ws server.Jan 29 2024, 4:17 PM
will retitled this revision from [services] [7/n] Replaces sending messages with `send_message` function to [identity] [7/n] Replaces sending messages with `send_message` function.Jan 30 2024, 11:07 AM
bartek accepted this revision.Jan 31 2024, 2:22 AM
This revision is now accepted and ready to land.Jan 31 2024, 2:22 AM
Closed by commit rCOMMcf573294103b: [identity] [7/n] Replaces sending messages with `send_message` function (authored by will). · Explain WhyJan 31 2024, 2:52 PM
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMcf573294103b: [identity] [7/n] Replaces sending messages with `send_message` function.

Revision Contents
Changeset List

PathSize
services/
identity/
src/
websockets/
23 lines

Diff 36490

View Options

services/identity/src/websockets/mod.rs

Loading...