This lets us get the nonce that we will use later in the SIWE message sent to the identity service
Depends on D10836
Details
Details
tested in next diff by actually dispatching the action and logging the nonce
Diff Detail
Diff Detail
- Repository
- rCOMM Comm
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
| lib/actions/user-actions.js | ||
|---|---|---|
| 428–431 ↗ | (On Diff #36363) | We can consider replacing this check with invariant. It is always a programmer error when this hook is used in a place where IdentityClientContext isn't provided. After this change we should be also able to replace the callback with a simple return return identityClient.generateNonce;. |
| lib/types/redux-types.js | ||
| 423 ↗ | (On Diff #36363) | Are you sure this should be void? Shouldn't this be a string? |
| native/identity-service/identity-service-context-provider.react.js | ||
| 267–269 ↗ | (On Diff #36363) | This doesn't need to be async - we're not awaiting anything. Also, the whole thing can be (probably) simplified. |
| web/grpc/identity-service-client-wrapper.js | ||
| 318–320 ↗ | (On Diff #36363) | We don't need this check because unauthClient is mandatory |
| lib/types/redux-types.js | ||
|---|---|---|
| 423 ↗ | (On Diff #36363) | Best to avoid making payload a string... I'd rather have an object payload with a single string inside |
| lib/actions/user-actions.js | ||
|---|---|---|
| 420 ↗ | (On Diff #36363) | this should be identityGenerateNonceActionTypes |