Page MenuHomePhabricator
Differential D10969

[lib] Introduce `ServerLegacyRoleInfo`
ClosedPublic
Actions

Authored by atul on Feb 6 2024, 11:08 AM.
Tags
None
Referenced Files
F1801127: D10969.diff
Mon, May 20, 7:40 AM
Unknown Object (File)
Apr 8 2024, 9:42 AM
Unknown Object (File)
Apr 8 2024, 9:42 AM
Unknown Object (File)
Apr 8 2024, 9:42 AM
Unknown Object (File)
Apr 8 2024, 9:42 AM
Unknown Object (File)
Apr 8 2024, 9:42 AM
Unknown Object (File)
Apr 8 2024, 9:42 AM
Unknown Object (File)
Mar 5 2024, 3:24 AM
View All 25 Files
Subscribers
None

Details

Reviewers
ginsu
tomek
Commits
rCOMM1cb9081f4e66: [lib] Introduce `ServerLegacyRoleInfo`
Summary

This is the Server-equivalent of ClientLegacyRoleInfo which was renamed from LegacyRoleInfo in D10968.

Why are we introducing a type without using it anywhere?

This type really should have been introduced as part of D10105. It will be immediately consumed by D10106 which will be sequenced after this diff, but didn't think it made sense to consolidate into one diff.

Depends on D10968

Test Plan

Will be tested implicitly via D10106 and by rest of stack.

Diff Detail

Repository
rCOMM Comm
Branch
arcpatch-D10969 (branched from master)
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

atul created this revision.Feb 6 2024, 11:08 AM
atul published this revision for review.Feb 6 2024, 11:09 AM
atul retitled this revision from [lib] Introduce `ServerClientLegacyRoleInfo` to [lib] Introduce `ServerLegacyRoleInfo`.Feb 6 2024, 11:12 AM
atul updated this revision to Diff 36724.Feb 6 2024, 11:12 AM

fix name

Harbormaster completed remote builds in B26575: Diff 36723.Feb 6 2024, 11:26 AM
Harbormaster completed remote builds in B26576: Diff 36724.Feb 6 2024, 11:53 AM
atul added a child revision: D10106: [keyserver] Update `fetchRoles(threadID: string)` to fetch special_role.Feb 6 2024, 11:55 AM
atul removed a reviewer: ashoat.Feb 7 2024, 11:00 AM
ginsu accepted this revision.Feb 7 2024, 12:23 PM
This revision is now accepted and ready to land.Feb 7 2024, 12:23 PM
atul updated this revision to Diff 36799.Feb 7 2024, 12:37 PM

land

This revision was landed with ongoing or failed builds.Feb 7 2024, 12:39 PM
Closed by commit rCOMM1cb9081f4e66: [lib] Introduce `ServerLegacyRoleInfo` (authored by atul). · Explain Why
This revision was automatically updated to reflect the committed changes.
atul added a commit: rCOMM1cb9081f4e66: [lib] Introduce `ServerLegacyRoleInfo`.
Harbormaster completed remote builds in B26630: Diff 36799.Feb 7 2024, 12:55 PM

Revision Contents
Changeset List

PathSize
lib/
types/
9 lines

Diff 36799

View Options

lib/types/thread-types.js

Loading...