[lib] Add `rolesWithoutSpecialRoleField` filter to `rawThreadInfoFromServerThreadInfo`
ClosedPublic
Actions

Authored by atul on Feb 7 2024, 1:20 PM.

Details

Reviewers

ginsu
tomek

Commits

rCOMM3cdfe501d658: [lib] Add `rolesWithoutSpecialRoleField` filter to…

Summary

This is to strip specialRoles out of roles before it's included in the rawThreadInfo: any that's being constructed.

ServerThreadInfo.roles contain specialRole, but RawThreadInfo does not. This change ensures that we construct a properly formed RawThreadInfo.

We will patch the specialRole field back in to minimally encoded RawThreadInfos for future clients (where shouldMinimallyEncodePermissions AND includeSpecialRoleFieldInRoles are true).

This makes D10107 safe to land since as of this diff we're stripping out the specialRole field altogether so there shouldn't be issues with any validators.

Depends on D10975

Test Plan

Logged result of function before and observed specialRole:

Logged result of function after and observed ABSENCE of specialRole:

Diff Detail

Repository

rCOMM Comm

Branch

master

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

atul created this revision.Feb 7 2024, 1:20 PM

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 7 2024, 1:20 PM

atul edited the test plan for this revision. (Show Details)Feb 7 2024, 1:23 PM

atul published this revision for review.Feb 7 2024, 1:30 PM

atul edited the test plan for this revision. (Show Details)

atul mentioned this in D10107: [keyserver] Update `fetchServerThreadInfos(filter?: FetchThreadInfosFilter)` to fetch special_role.

Harbormaster completed remote builds in B26632: Diff 36803.Feb 7 2024, 1:37 PM

We will patch the specialRole field back in to minimally encoded RawThreadInfos for future clients (where shouldMinimallyEncodePermissions AND includeSpecialRoleFieldInRoles are true).

Is it something already handled in the stack?

This revision is now accepted and ready to land.Feb 8 2024, 2:27 AM

In D10990#317334, @tomek wrote:

We will patch the specialRole field back in to minimally encoded RawThreadInfos for future clients (where shouldMinimallyEncodePermissions AND includeSpecialRoleFieldInRoles are true).

Is it something already handled in the stack?

Will be handled in subsequent diff in the stack

land

This revision was landed with ongoing or failed builds.Feb 8 2024, 9:39 AM

Closed by commit rCOMM3cdfe501d658: [lib] Add `rolesWithoutSpecialRoleField` filter to… (authored by atul). · Explain Why

This revision was automatically updated to reflect the committed changes.

atul added a commit: rCOMM3cdfe501d658: [lib] Add `rolesWithoutSpecialRoleField` filter to….

Harbormaster failed remote builds in B26656: Diff 36858!Feb 8 2024, 9:39 AM