Page MenuHomePhabricator
Differential D10996

[identity] Remove usage of sending raw error messages to client
ClosedPublic
Actions

Authored by will on Feb 8 2024, 10:19 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sun, Mar 30, 12:26 AM
Unknown Object (File)
Fri, Mar 7, 9:42 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
Unknown Object (File)
Feb 15 2025, 10:53 PM
View All Files
Subscribers
ashoat
tomek

Details

Reviewers
varun
bartek
Commits
rCOMMb47b0f14519b: [identity] Remove usage of sending raw error messages to client
Summary

This removes usage of raw error messages that are not part of identity search message types.

Depends on D10945

Test Plan

ran and verified on local dev through cargo run

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

will created this revision.Feb 8 2024, 10:19 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 8 2024, 10:19 AM
will edited the summary of this revision. (Show Details)Feb 8 2024, 10:20 AM
will added a parent revision: D10945: [identity] [shared] Separate identity search messages into client and server messages.
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 8 2024, 10:22 AM
Harbormaster failed remote builds in B26660: Diff 36868!
will added a child revision: D10928: [lib] Add types for identity search websocket server.Feb 8 2024, 10:56 AM
will requested review of this revision.Feb 8 2024, 11:45 AM
will updated this revision to Diff 37015.Feb 13 2024, 12:31 AM

rebase

Harbormaster completed remote builds in B26775: Diff 37015.Feb 13 2024, 12:46 AM
varun accepted this revision.Feb 13 2024, 11:21 AM
This revision is now accepted and ready to land.Feb 13 2024, 11:21 AM
will updated this revision to Diff 37365.Feb 20 2024, 7:08 AM

rebase

Harbormaster completed remote builds in B27004: Diff 37365.Feb 20 2024, 7:24 AM
will added a child revision: D11162: [identity] Configure identity search to return 20 search results.Feb 25 2024, 1:02 PM
will updated this revision to Diff 37559.Feb 25 2024, 1:27 PM

rebase

will edited the summary of this revision. (Show Details)Feb 25 2024, 1:33 PM
Harbormaster failed remote builds in B27142: Diff 37559!Feb 25 2024, 1:38 PM
will edited the summary of this revision. (Show Details)Feb 25 2024, 1:39 PM
will edited the summary of this revision. (Show Details)
will removed a child revision: D10928: [lib] Add types for identity search websocket server.Feb 25 2024, 2:09 PM
This revision was landed with ongoing or failed builds.Feb 26 2024, 12:54 PM
Closed by commit rCOMMb47b0f14519b: [identity] Remove usage of sending raw error messages to client (authored by will). · Explain Why
This revision was automatically updated to reflect the committed changes.
will added a commit: rCOMMb47b0f14519b: [identity] Remove usage of sending raw error messages to client.
Harbormaster completed remote builds in B27142: Diff 37559.Feb 26 2024, 2:46 PM

Revision Contents
Changeset List

PathSize
services/
identity/
src/
websockets/
4 lines
24 lines

Diff 36868

View Options

services/identity/src/websockets/mod.rs

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;
View Options

services/identity/src/websockets/send.rs

Show First 20 Lines • Show All 188 Lines • ▼ Show 20 Linesdeclare export class SQLiteQueryExecutor {
markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void; markOutboundP2PMessageAsSent(messageID: string, deviceID: string): void;
addInboundP2PMessage(message: InboundP2PMessage): void; addInboundP2PMessage(message: InboundP2PMessage): void;
getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>; getAllInboundP2PMessage(): $ReadOnlyArray<InboundP2PMessage>;
removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void; removeInboundP2PMessages(ids: $ReadOnlyArray<string>): void;
getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>; getRelatedMessagesWeb(id: string): $ReadOnlyArray<MessageEntity>;
updateMessageSearchIndex(
originalMessageID: string,
messageID: string,
content: string,
): void;
// method is provided to manually signal that a C++ object // method is provided to manually signal that a C++ object
// is no longer needed and can be deleted // is no longer needed and can be deleted
delete(): void; delete(): void;
} }
export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor; export type SQLiteQueryExecutorType = typeof SQLiteQueryExecutor;