[web] use identity service to set SIWE nonce in siwe-login-form
ClosedPublic
Actions

Authored by varun on Feb 9 2024, 10:45 AM.

Details

Reviewers

ashoat
inka
tomek

Commits

rCOMM81bc05508c6c: [web] use identity service to set SIWE nonce in siwe-login-form

Summary

if usingCommServicesAccessToken, we should get the nonce from the identity service and set the state variable to that value

Depends on D11018

Test Plan

verified that the action was successful in redux, console logged the state variable to confirm it was set

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 9 2024, 10:45 AM

varun added a child revision: D11020: [web] use identity wallet login in siwe-login-form.Feb 9 2024, 10:48 AM

Harbormaster completed remote builds in B26722: Diff 36948.Feb 9 2024, 10:59 AM

varun requested review of this revision.Feb 9 2024, 10:59 AM

ashoat accepted this revision.Feb 9 2024, 11:23 AM

This revision is now accepted and ready to land.Feb 9 2024, 11:23 AM

I think this would have to be reconsidered if we want a fallback mechanism

In D11019#320754, @ashoat wrote:

I think this would have to be reconsidered if we want a fallback mechanism

https://linear.app/comm/issue/ENG-6881/fallback-mechanism-for-login-and-registration#comment-9445e916

Closed by commit rCOMM81bc05508c6c: [web] use identity service to set SIWE nonce in siwe-login-form (authored by varun). · Explain WhyFeb 22 2024, 8:17 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM81bc05508c6c: [web] use identity service to set SIWE nonce in siwe-login-form.

Revision Contents
Changeset List

Path

Size

web/

account/

siwe-login-form.react.js

47 lines

Diff 37470

View Options

web/account/siwe-login-form.react.js

[web] use identity service to set SIWE nonce in siwe-login-formClosedPublicActions