[native] call identity wallet login from ExistingEthereumAccount
ClosedPublic
Actions

Authored by varun on Feb 15 2024, 8:11 PM.

Details

Reviewers

ashoat
inka
tomek

Commits

rCOMMdee6a3960874: [native] call identity wallet login from ExistingEthereumAccount

Summary

if usingCommServicesAccessToken is set, we should use identity wallet login here instead of the legacy keyserver call

Depends on D11016

Test Plan

successfully logged in to identity service from ExistingEthereumAccount. also tested that the alert displayed when identity service was down during login attempt

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 15 2024, 8:11 PM

Harbormaster completed remote builds in B26946: Diff 37289.Feb 15 2024, 8:25 PM

varun requested review of this revision.Feb 15 2024, 8:25 PM

varun added a child revision: D11017: [native] use identity wallet registration from final step of new registration workflow.Feb 15 2024, 8:38 PM

tomek accepted this revision.Feb 16 2024, 2:18 AM

tomek added inline comments.

native/account/registration/existing-ethereum-account.react.js
76 ↗	(On Diff #37289)	Not a part of this diff, but we need to make sure that in the new flow, this gets set.

This revision is now accepted and ready to land.Feb 16 2024, 2:18 AM

Wondering about a fallback mechanism here

varun added inline comments.Feb 22 2024, 8:04 PM

native/account/registration/existing-ethereum-account.react.js
76 ↗	(On Diff #37289)	i think we only want to set this after we've successfully authenticated with @ashoat 's keyserver. if i'm wrong please let me know and i'll create a follow-up task