[identity] Merge Identity auth response messages
ClosedPublic
Actions

Authored by varun on Feb 13 2024, 7:42 PM.

Details

Reviewers

ashoat
bartek

Commits

rCOMMb75dafccde2e: [identity] Merge Identity auth response messages

Summary

Resolves ENG-6686. Wanted to tackle this before introducing the RegisterWalletUser RPC.

Test Plan

identity service builds successfully and flow passes on web

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 13 2024, 7:42 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 13 2024, 7:43 PM

varun added a parent revision: D11052: [identity] move findUserID to unauth proto.Feb 13 2024, 7:44 PM

Harbormaster completed remote builds in B26809: Diff 37052.Feb 13 2024, 7:57 PM

varun requested review of this revision.Feb 13 2024, 7:57 PM

varun added a child revision: D11062: [identity] rename LogInReservedWalletUser -> RegisterReservedWalletUser.Feb 13 2024, 8:04 PM

Thanks for doing this!

ashoat accepted this revision.Feb 14 2024, 10:36 AM

This revision is now accepted and ready to land.Feb 14 2024, 10:36 AM

Closed by commit rCOMMb75dafccde2e: [identity] Merge Identity auth response messages (authored by varun). · Explain WhyFeb 15 2024, 9:02 AM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMb75dafccde2e: [identity] Merge Identity auth response messages.

varun mentioned this in D10861: [identity] Add RPC for secondary device login.Feb 15 2024, 9:05 AM

Revision Contents
Changeset List

Path

Size

services/

identity/

src/

client_service.rs

32 lines

shared/

protos/

identity_unauth.proto

25 lines

web/

protobufs/

identity-unauth-structs.cjs

identity-unauth-structs.cjs.flow

58 lines

identity-unauth.cjs

identity-unauth.cjs.flow

24 lines

Diff 37267

View Options

services/identity/src/client_service.rs

View Options

shared/protos/identity_unauth.proto

View Options

web/protobufs/identity-unauth-structs.cjs

View Options

web/protobufs/identity-unauth-structs.cjs.flow

View Options

web/protobufs/identity-unauth.cjs

View Options

web/protobufs/identity-unauth.cjs.flow

[identity] Merge Identity auth response messagesClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37267

services/identity/src/client_service.rs

shared/protos/identity_unauth.proto

web/protobufs/identity-unauth-structs.cjs

web/protobufs/identity-unauth-structs.cjs.flow

web/protobufs/identity-unauth.cjs

web/protobufs/identity-unauth.cjs.flow

[identity] Merge Identity auth response messages
ClosedPublic
Actions

Revision Contents
Changeset List