Page MenuHomePhabricator
Differential D11061

[identity] Merge Identity auth response messages
ClosedPublic
Actions

Authored by varun on Feb 13 2024, 7:42 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Mar 31, 5:29 AM
Unknown Object (File)
Thu, Mar 13, 11:04 PM
Unknown Object (File)
Fri, Mar 7, 8:14 PM
Unknown Object (File)
Wed, Mar 5, 4:43 PM
Unknown Object (File)
Feb 27 2025, 3:45 AM
Unknown Object (File)
Feb 22 2025, 9:36 AM
Unknown Object (File)
Feb 22 2025, 9:36 AM
Unknown Object (File)
Feb 22 2025, 9:35 AM
View All 78 Files
Subscribers
tomek

Details

Reviewers
ashoat
bartek
Commits
rCOMMb75dafccde2e: [identity] Merge Identity auth response messages
Summary

Resolves ENG-6686. Wanted to tackle this before introducing the RegisterWalletUser RPC.

Test Plan

identity service builds successfully and flow passes on web

Diff Detail

Repository
rCOMM Comm
Lint
No Lint Coverage
Unit
No Test Coverage

Revision Contents
Changeset List

Diff 37052

View Options

services/identity/src/client_service.rs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

shared/protos/identity_unauth.proto

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

web/protobufs/identity-unauth-structs.cjs

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

web/protobufs/identity-unauth-structs.cjs.flow

// @flow // @flow
import invariant from 'invariant'; import invariant from 'invariant';
import { specialRoles } from 'lib/permissions/special-roles.js'; import { specialRoles } from 'lib/permissions/special-roles.js';
import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js'; import { getAllThreadPermissions } from 'lib/permissions/thread-permissions.js';
import { import {
rawThreadInfoFromServerThreadInfo, rawThreadInfoFromServerThreadInfo,
getContainingThreadID, getContainingThreadID,
getCommunity, getCommunity,
} from 'lib/shared/thread-utils.js'; } from 'lib/shared/thread-utils.js';
import { hasMinCodeVersion } from 'lib/shared/version-utils.js'; import {
FUTURE_CODE_VERSION,
hasMinCodeVersion,
} from 'lib/shared/version-utils.js';
import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js'; import type { AvatarDBContent, ClientAvatar } from 'lib/types/avatar-types.js';
import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js'; import type { RawMessageInfo, MessageInfo } from 'lib/types/message-types.js';
import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js'; import type { RawThreadInfo } from 'lib/types/minimally-encoded-thread-permissions-types.js';
import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js'; import { threadTypes, type ThreadType } from 'lib/types/thread-types-enum.js';
import { import {
type ServerThreadInfo, type ServerThreadInfo,
type MixedRawThreadInfos, type MixedRawThreadInfos,
type LegacyRawThreadInfo, type LegacyRawThreadInfo,
▲ Show 20 Lines • Show All 259 Lines • ▼ Show 20 Lines): FetchThreadInfosResult {
}); });
const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, { const codeVersionBelow283 = !hasMinCodeVersion(viewer.platformDetails, {
native: 285, native: 285,
}); });
const minimallyEncodedPermissionsSupported = hasMinCodeVersion( const minimallyEncodedPermissionsSupported = hasMinCodeVersion(
viewer.platformDetails, viewer.platformDetails,
{ native: 301, web: 56 }, { native: 301, web: 56 },
); );
const futureCodeVersion = hasMinCodeVersion(viewer.platformDetails, {
native: FUTURE_CODE_VERSION,
web: FUTURE_CODE_VERSION,
majorDesktop: FUTURE_CODE_VERSION,
});
const threadInfos: { const threadInfos: {
[string]: LegacyRawThreadInfo | RawThreadInfo, [string]: LegacyRawThreadInfo | RawThreadInfo,
} = {}; } = {};
for (const threadID in serverResult.threadInfos) { for (const threadID in serverResult.threadInfos) {
const serverThreadInfo = serverResult.threadInfos[threadID]; const serverThreadInfo = serverResult.threadInfos[threadID];
const threadInfo = rawThreadInfoFromServerThreadInfo( const threadInfo = rawThreadInfoFromServerThreadInfo(
serverThreadInfo, serverThreadInfo,
viewerID, viewerID,
{ {
filterThreadEditAvatarPermission: codeVersionBelow213, filterThreadEditAvatarPermission: codeVersionBelow213,
excludePinInfo: codeVersionBelow209, excludePinInfo: codeVersionBelow209,
filterManageInviteLinksPermission: codeVersionBelow221, filterManageInviteLinksPermission: codeVersionBelow221,
filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283, filterVoicedInAnnouncementChannelsPermission: codeVersionBelow283,
minimallyEncodePermissions: minimallyEncodedPermissionsSupported, minimallyEncodePermissions: minimallyEncodedPermissionsSupported,
includeSpecialRoleFieldInRoles: futureCodeVersion,
}, },
); );
if (threadInfo) { if (threadInfo) {
threadInfos[threadID] = threadInfo; threadInfos[threadID] = threadInfo;
} }
} }
return { threadInfos }; return { threadInfos };
} }
▲ Show 20 Lines • Show All 116 Lines • Show Last 20 Lines
View Options

web/protobufs/identity-unauth.cjs

Loading...
View Options

web/protobufs/identity-unauth.cjs.flow

Loading...