Page MenuHomePhabricator
Differential D11081

[native] add CommRustModule bindings for registerWalletUser
ClosedPublic
Actions

Authored by varun on Feb 14 2024, 10:48 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 4:17 AM
Unknown Object (File)
Tue, Dec 24, 4:17 AM
Unknown Object (File)
Tue, Dec 24, 4:17 AM
Unknown Object (File)
Tue, Dec 24, 4:16 AM
Unknown Object (File)
Thu, Nov 28, 6:18 AM
Unknown Object (File)
Thu, Nov 28, 2:00 AM
Unknown Object (File)
Nov 24 2024, 2:38 PM
Unknown Object (File)
Nov 24 2024, 11:34 AM
View All 53 Files
Subscribers
bartek
kamil
tomek

Details

Reviewers
kamil
bartek
Commits
rCOMMaa72c35016ae: [native] add CommRustModule bindings for registerWalletUser
Summary

These bindings will be used by the native IdentityServiceContextProvider in the subsequent diff

Depends on D11080

Test Plan

successfully built app for iOS simulator

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun created this revision.Feb 14 2024, 10:48 AM
Herald added a subscriber: tomek. · View Herald TranscriptFeb 14 2024, 10:48 AM
varun added a child revision: D11082: [native][lib] add registerWalletUser to native IdentityServiceContextProvider.Feb 14 2024, 10:59 AM
Harbormaster completed remote builds in B26839: Diff 37102.Feb 14 2024, 11:03 AM
varun requested review of this revision.Feb 14 2024, 11:03 AM
ashoat resigned from this revision.Feb 14 2024, 12:47 PM
ashoat edited reviewers, added: kamil, bartek; removed: ashoat.
ashoat added subscribers: bartek, kamil.

Looks good to me, but I'm not super familiar with CommRustModule stuff. Ran git blame on the schema file and I think either @kamil or @bartek would be a good reviewer here

bartek accepted this revision.Feb 15 2024, 10:11 PM
This revision is now accepted and ready to land.Feb 15 2024, 10:11 PM
kamil accepted this revision.Feb 16 2024, 6:52 AM
Closed by commit rCOMMaa72c35016ae: [native] add CommRustModule bindings for registerWalletUser (authored by varun). · Explain WhyFeb 16 2024, 7:20 AM
This revision was automatically updated to reflect the committed changes.
varun added a commit: rCOMMaa72c35016ae: [native] add CommRustModule bindings for registerWalletUser.

Revision Contents
Changeset List

PathSize
native/
cpp/
CommonCpp/
NativeModules/
12 lines
53 lines
_generated/
schema/
12 lines

Diff 37310

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

Loading...
View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

Loading...
View Options

native/cpp/CommonCpp/_generated/rustJSI.h

Loading...
View Options

native/schema/CommRustModuleSchema.js

Loading...