Paths

Table of Contentst

[native] add CommRustModule bindings for registerWalletUser
ClosedPublic
Actions

Authored by varun on Feb 14 2024, 6:48 PM.

Details

Reviewers

kamil
bartek

Commits

rCOMMaa72c35016ae: [native] add CommRustModule bindings for registerWalletUser

Summary

These bindings will be used by the native IdentityServiceContextProvider in the subsequent diff

Depends on D11080

Test Plan

successfully built app for iOS simulator

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 14 2024, 6:48 PM

Herald added a subscriber: tomek. · View Herald TranscriptFeb 14 2024, 6:48 PM

varun added a child revision: D11082: [native][lib] add registerWalletUser to native IdentityServiceContextProvider.Feb 14 2024, 6:59 PM

Harbormaster completed remote builds in B26839: Diff 37102.Feb 14 2024, 7:03 PM

varun requested review of this revision.Feb 14 2024, 7:03 PM

Looks good to me, but I'm not super familiar with CommRustModule stuff. Ran git blame on the schema file and I think either @kamil or @bartek would be a good reviewer here

bartek accepted this revision.Feb 16 2024, 6:11 AM

This revision is now accepted and ready to land.Feb 16 2024, 6:11 AM

kamil accepted this revision.Feb 16 2024, 2:52 PM

Closed by commit rCOMMaa72c35016ae: [native] add CommRustModule bindings for registerWalletUser. · Explain WhyFeb 16 2024, 3:20 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMMaa72c35016ae: [native] add CommRustModule bindings for registerWalletUser.

Revision Contents
Changeset List

Path

Size

native/

cpp/

CommonCpp/

NativeModules/

CommRustModule.h

12 lines

CommRustModule.cpp

53 lines

_generated/

rustJSI-generated.cpp

rustJSI.h

schema/

CommRustModuleSchema.js

12 lines

Diff 37310

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.h

View Options

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

View Options

native/cpp/CommonCpp/_generated/rustJSI.h

View Options

native/schema/CommRustModuleSchema.js

[native] add CommRustModule bindings for registerWalletUserClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 37310

native/cpp/CommonCpp/NativeModules/CommRustModule.h

native/cpp/CommonCpp/NativeModules/CommRustModule.cpp

native/cpp/CommonCpp/_generated/rustJSI-generated.cpp

native/cpp/CommonCpp/_generated/rustJSI.h

native/schema/CommRustModuleSchema.js

[native] add CommRustModule bindings for registerWalletUser
ClosedPublic
Actions

Revision Contents
Changeset List