Page MenuHomePhabricator

[native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken
ClosedPublic

Authored by varun on Feb 9 2024, 10:39 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Dec 24, 4:02 AM
Unknown Object (File)
Tue, Dec 24, 4:02 AM
Unknown Object (File)
Tue, Dec 24, 4:02 AM
Unknown Object (File)
Tue, Dec 24, 4:02 AM
Unknown Object (File)
Tue, Dec 24, 4:02 AM
Unknown Object (File)
Sun, Dec 22, 4:21 PM
Unknown Object (File)
Nov 17 2024, 12:41 AM
Unknown Object (File)
Nov 16 2024, 10:45 PM
Subscribers

Details

Summary

use FindUserID RPC to check if wallet address is associated with existing account

Depends on D11005

Test Plan

successfully navigated to ExistingEthereumAccount with usingCommServicesAccessToken set when trying to register with my already-registered eth wallet

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

varun requested review of this revision.Feb 9 2024, 10:54 AM
ashoat requested changes to this revision.Feb 9 2024, 11:21 AM
This revision now requires changes to proceed.Feb 9 2024, 11:21 AM
varun requested review of this revision.Feb 9 2024, 11:23 AM

i don't see any review comments @ashoat

Yeah I wasn't sure what to say. I'm struggling to understand why this diff was submitted.

The product functionality needs to be remain unchanged. Existing Ethereum accounts should not go through the registration flow. There's no world where we can just "break" this. It feels like you're trying to avoid work because you hadn't scoped it previously.

The auth / unauth stuff also makes no sense to me. Isn't the whole point of @will's work to move exactSearchUserCall to the identity service?

Yeah I wasn't sure what to say. I'm struggling to understand why this diff was submitted.

ok, not sure how just pushing it back to my queue was productive, though...

The product functionality needs to be remain unchanged. Existing Ethereum accounts should not go through the registration flow. There's no world where we can just "break" this. It feels like you're trying to avoid work because you hadn't scoped it previously.

you're right, i should have scoped this better. i'll think more about how to avoid breaking the existing product functionality.

The auth / unauth stuff also makes no sense to me. Isn't the whole point of @will's work to move exactSearchUserCall to the identity service?

my understanding was @will's work moves searchUsers to the identity service, but it seems reasonable to use that work for an exact user search, too. however, it's also currently designed as an auth API, so it won't work without a CSAT

Ah so the API is already built then, and just needs to be moved between protos. Great

use findUserID RPC to check if there is an existing account for wallet address

varun retitled this revision from [native] don't navigate to ExistingEthereumAccount if usingCommServicesAccessToken to [native] logic for navigating to ExistingEthereumAccount if usingCommServicesAccessToken.Feb 15 2024, 8:37 PM
varun edited the summary of this revision. (Show Details)
varun edited the test plan for this revision. (Show Details)

Should we "fall back" to the legacy workflow if the new one doesn't work?

Should we "fall back" to the legacy workflow if the new one doesn't work?

we have a new plan instead of a fallback mechanism including automated alerts, daily manual testing, and an opt-in mechanism for clients to inform us when there are issues

This revision is now accepted and ready to land.Feb 22 2024, 7:43 PM