[web] use identity wallet login in siwe-login-form
ClosedPublic
Actions

Authored by varun on Feb 9 2024, 10:48 AM.

Details

Reviewers

ashoat
inka
tomek

Commits

rCOMM507a3adde3c1: [web] use identity wallet login in siwe-login-form

Summary

If usingCommServicesAccessToken, call identity service wallet login RPC.

Depends on D11019

Test Plan

Confirmed that action succeeded in redux devtools, inspected payload and confirmed that the access token and user ID matched local DDB

Diff Detail

Repository

rCOMM Comm

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

varun created this revision.Feb 9 2024, 10:48 AM

Harbormaster completed remote builds in B26723: Diff 36949.Feb 9 2024, 11:02 AM

varun requested review of this revision.Feb 9 2024, 11:02 AM

varun added a child revision: D11021: [native] call setCommServicesAuthMetadata on identity registration and login.Feb 9 2024, 11:18 AM

ashoat requested changes to this revision.Feb 9 2024, 11:24 AM

ashoat added inline comments.

web/account/siwe-login-form.react.js
138 ↗	(On Diff #36949)	You'll need to find a way to replicate this

This revision now requires changes to proceed.Feb 9 2024, 11:24 AM

varun added inline comments.Feb 15 2024, 8:42 PM

web/account/siwe-login-form.react.js
138 ↗	(On Diff #36949)	now that we've separated wallet login and registration RPCs, calling login ensures that we don't register a new account

match existing error handling

Harbormaster completed remote builds in B26948: Diff 37291.Feb 15 2024, 9:05 PM

Are we planning a "fallback" mechanism here?

In D11020#320733, @ashoat wrote:

Are we planning a "fallback" mechanism here?

we have a new plan instead of a fallback mechanism including automated alerts, daily manual testing, and an opt-in mechanism for clients to inform us when there are issues

ashoat accepted this revision.Feb 22 2024, 7:44 PM

This revision is now accepted and ready to land.Feb 22 2024, 7:44 PM

Closed by commit rCOMM507a3adde3c1: [web] use identity wallet login in siwe-login-form (authored by varun). · Explain WhyFeb 22 2024, 8:17 PM

This revision was automatically updated to reflect the committed changes.

varun added a commit: rCOMM507a3adde3c1: [web] use identity wallet login in siwe-login-form.

Revision Contents
Changeset List

Path

Size

web/

account/

siwe-login-form.react.js

48 lines

Diff 37471

View Options

web/account/siwe-login-form.react.js

// @flow		// @flow

		import invariant from 'invariant';
		import * as React from 'react';
import uuid from 'uuid';		import uuid from 'uuid';

import blobService from '../facts/blob-service.js';		import blobService from '../facts/blob-service.js';
import { extractKeyserverIDFromID } from '../keyserver-conn/keyserver-call-utils.js';		import { extractKeyserverIDFromID } from '../keyserver-conn/keyserver-call-utils.js';
import type { CallKeyserverEndpoint } from '../keyserver-conn/keyserver-conn-types.js';		import type { CallKeyserverEndpoint } from '../keyserver-conn/keyserver-conn-types.js';
		import { IdentityClientContext } from '../shared/identity-client-context.js';
		import type { AuthMetadata } from '../shared/identity-client-context.js';
import type { UploadMultimediaResult, Dimensions } from '../types/media-types';		import type { UploadMultimediaResult, Dimensions } from '../types/media-types';
import { toBase64URL } from '../utils/base64.js';		import { toBase64URL } from '../utils/base64.js';
import {		import {
blobServiceUploadHandler,		blobServiceUploadHandler,
type BlobServiceUploadHandler,		type BlobServiceUploadHandler,
} from '../utils/blob-service-upload.js';		} from '../utils/blob-service-upload.js';
import { makeBlobServiceEndpointURL } from '../utils/blob-service.js';		import { makeBlobServiceEndpointURL } from '../utils/blob-service.js';
import type { CallSingleKeyserverEndpoint } from '../utils/call-single-keyserver-endpoint.js';		import type { CallSingleKeyserverEndpoint } from '../utils/call-single-keyserver-endpoint.js';
import { getMessageForException } from '../utils/errors.js';		import { getMessageForException } from '../utils/errors.js';
import { useKeyserverCall } from '../utils/keyserver-call.js';		import { useKeyserverCall } from '../utils/keyserver-call.js';
import { handleHTTPResponseError } from '../utils/services-utils.js';		import {
		handleHTTPResponseError,
		createDefaultHTTPRequestHeaders,
		} from '../utils/services-utils.js';
import { type UploadBlob } from '../utils/upload-blob.js';		import { type UploadBlob } from '../utils/upload-blob.js';

export type MultimediaUploadCallbacks = Partial<{		export type MultimediaUploadCallbacks = Partial<{
+onProgress: (percent: number) => void,		+onProgress: (percent: number) => void,
+abortHandler: (abort: () => void) => void,		+abortHandler: (abort: () => void) => void,
+uploadBlob: UploadBlob,		+uploadBlob: UploadBlob,
+blobServiceUploadHandler: BlobServiceUploadHandler,		+blobServiceUploadHandler: BlobServiceUploadHandler,
+timeout: ?number,		+timeout: ?number,
▲ Show 20 Lines • Show All 112 Lines • ▼ Show 20 Lines

export type BlobServiceUploadAction = (input: {		export type BlobServiceUploadAction = (input: {
+uploadInput: BlobServiceUploadInput,		+uploadInput: BlobServiceUploadInput,
+keyserverOrThreadID: string,		+keyserverOrThreadID: string,
+callbacks?: MultimediaUploadCallbacks,		+callbacks?: MultimediaUploadCallbacks,
}) => Promise<BlobServiceUploadResult>;		}) => Promise<BlobServiceUploadResult>;

const blobServiceUpload =		const blobServiceUpload =
(callKeyserverEndpoint: CallKeyserverEndpoint): BlobServiceUploadAction =>		(
		callKeyserverEndpoint: CallKeyserverEndpoint,
		authMetadata: AuthMetadata,
		): BlobServiceUploadAction =>
async input => {		async input => {
const { uploadInput, callbacks, keyserverOrThreadID } = input;		const { uploadInput, callbacks, keyserverOrThreadID } = input;
const { encryptionKey, loop, dimensions, thumbHash, blobInput } =		const { encryptionKey, loop, dimensions, thumbHash, blobInput } =
uploadInput;		uploadInput;
const blobHolder = uuid.v4();		const blobHolder = uuid.v4();
const blobHash = toBase64URL(uploadInput.blobHash);		const blobHash = toBase64URL(uploadInput.blobHash);
		const defaultHeaders = createDefaultHTTPRequestHeaders(authMetadata);

// 1. Assign new holder for blob with given blobHash		// 1. Assign new holder for blob with given blobHash
let blobAlreadyExists: boolean;		let blobAlreadyExists: boolean;
try {		try {
const assignHolderEndpoint = blobService.httpEndpoints.ASSIGN_HOLDER;		const assignHolderEndpoint = blobService.httpEndpoints.ASSIGN_HOLDER;
const assignHolderResponse = await fetch(		const assignHolderResponse = await fetch(
makeBlobServiceEndpointURL(assignHolderEndpoint),		makeBlobServiceEndpointURL(assignHolderEndpoint),
{		{
method: assignHolderEndpoint.method,		method: assignHolderEndpoint.method,
body: JSON.stringify({		body: JSON.stringify({
holder: blobHolder,		holder: blobHolder,
blob_hash: blobHash,		blob_hash: blobHash,
}),		}),
headers: {		headers: {
		...defaultHeaders,
'content-type': 'application/json',		'content-type': 'application/json',
},		},
},		},
);		);
handleHTTPResponseError(assignHolderResponse);		handleHTTPResponseError(assignHolderResponse);
const { data_exists: dataExistsResponse } =		const { data_exists: dataExistsResponse } =
await assignHolderResponse.json();		await assignHolderResponse.json();
blobAlreadyExists = dataExistsResponse;		blobAlreadyExists = dataExistsResponse;
Show All 15 Lines	if (!blobAlreadyExists) {
try {		try {
await blobServiceUploadCallback(		await blobServiceUploadCallback(
makeBlobServiceEndpointURL(uploadEndpoint),		makeBlobServiceEndpointURL(uploadEndpoint),
uploadEndpoint.method,		uploadEndpoint.method,
{		{
blobHash,		blobHash,
blobInput,		blobInput,
},		},
		authMetadata,
{ ...callbacks },		{ ...callbacks },
);		);
} catch (e) {		} catch (e) {
throw new Error(		throw new Error(
`Failed to upload blob: ${		`Failed to upload blob: ${
getMessageForException(e) ?? 'unknown error'		getMessageForException(e) ?? 'unknown error'
}`,		}`,
);		);
Show All 28 Lines	return {
mediaType: response.mediaType,		mediaType: response.mediaType,
dimensions: response.dimensions,		dimensions: response.dimensions,
loop: response.loop,		loop: response.loop,
blobHolder,		blobHolder,
};		};
};		};

function useBlobServiceUpload(): BlobServiceUploadAction {		function useBlobServiceUpload(): BlobServiceUploadAction {
return useKeyserverCall(blobServiceUpload);		const identityContext = React.useContext(IdentityClientContext);
		invariant(identityContext, 'Identity context should be set');
		const { getAuthMetadata } = identityContext;

		const blobUploadAction = React.useCallback(
		(
		callSingleKeyserverEndpoint: CallSingleKeyserverEndpoint,
		): BlobServiceUploadAction =>
		async input => {
		const authMetadata = await getAuthMetadata();
		const authenticatedUploadAction = blobServiceUpload(
		callSingleKeyserverEndpoint,
		authMetadata,
		);
		return authenticatedUploadAction(input);
		},
		[getAuthMetadata],
		);
		return useKeyserverCall(blobUploadAction);
}		}

export {		export {
uploadMultimedia,		uploadMultimedia,
useBlobServiceUpload,		useBlobServiceUpload,
updateMultimediaMessageMediaActionType,		updateMultimediaMessageMediaActionType,
useDeleteUpload,		useDeleteUpload,
};		};

[web] use identity wallet login in siwe-login-formClosedPublicActions