Paths

Table of Contentst

Differential D11106

[crypto] unify key types and introduce type for Inbound Keys
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 7:35 AM.

Tags

None

Referenced Files

	F2154245: D11106.id37483.diff
	Sun, Jun 30, 6:51 PM

	Unknown Object (File)
	Sat, Jun 29, 1:19 PM

	Unknown Object (File)
	Thu, Jun 27, 3:07 PM

	Unknown Object (File)
	Thu, Jun 27, 12:05 PM

	Unknown Object (File)
	Tue, Jun 18, 5:13 AM

	Unknown Object (File)
	Wed, Jun 12, 1:28 AM

	Unknown Object (File)
	Sat, Jun 1, 5:38 PM

	Unknown Object (File)
	May 20 2024, 11:11 AM

View All 31 Files

Subscribers

Details

Reviewers

marcin
varun
tomek

Commits

rCOMM912919f516fc: [crypto] unify key types and introduce type for Inbound Keys

Summary

Move some types from CommCoreModuleSchema.js -> crypto-types.js
Add validator for SignedPrekeys
UserDevicesOlmInboundKeys type and validator
Group types in identity-service-types.js

Test Plan

FLow

Diff Detail

Repository

Branch

olm-web-4

Lint

No Lint Coverage

Unit

No Test Coverage

Event Timeline

kamil created this revision.Feb 19 2024, 7:35 AM

kamil held this revision as a draft.

Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 7:35 AM

kamil added a child revision: D11107: [web] implementing getting inbound user keys in `IdentityServiceClient`.Feb 19 2024, 7:46 AM

Harbormaster completed remote builds in B26964: Diff 37323.Feb 19 2024, 7:50 AM

kamil published this revision for review.Feb 19 2024, 9:35 AM

tomek accepted this revision.Feb 21 2024, 1:48 AM

tomek added inline comments.

lib/types/crypto-types.js
25–28	It might appear more convenient to have two fields, one for `content` and one for `notif`, each being an object with `prekey` and `prekeySignature`
lib/types/identity-service-types.js
87–88	Can these two be null at the same time? If not, then can we reflect that in the type?

This revision is now accepted and ready to land.Feb 21 2024, 1:48 AM

add validator

kamil added inline comments.Feb 22 2024, 7:58 AM

lib/types/crypto-types.js
25–28	I am just moving this type - it will require changing C++ code which returns prekeys
lib/types/identity-service-types.js
87–88	This is based on `InboundKeyInfoResponse` - but there is some ongoing work to improve it (https://phab.comm.dev/D11108#inline-67556)

Harbormaster failed remote builds in B27067: Diff 37445!Feb 22 2024, 8:03 AM

This revision was landed with ongoing or failed builds.Feb 23 2024, 1:32 AM

Closed by commit rCOMM912919f516fc: [crypto] unify key types and introduce type for Inbound Keys (authored by kamil). · Explain Why

This revision was automatically updated to reflect the committed changes.

kamil added a commit: rCOMM912919f516fc: [crypto] unify key types and introduce type for Inbound Keys.

Revision Contents
Changeset List

Path

Size

lib/

types/

crypto-types.js

20 lines

identity-service-types.js

50 lines

native/

schema/

CommCoreModuleSchema.js

14 lines

Diff 37323

lib/types/crypto-types.js

Loading...

lib/types/identity-service-types.js

Loading...

native/schema/CommCoreModuleSchema.js

Loading...