Page MenuHomePhabricator
Differential D11106

[crypto] unify key types and introduce type for Inbound Keys
ClosedPublic
Actions

Authored by kamil on Feb 19 2024, 7:35 AM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 6:26 AM
Unknown Object (File)
Fri, Nov 22, 3:15 PM
Unknown Object (File)
Fri, Nov 22, 11:09 AM
Unknown Object (File)
Sat, Nov 9, 4:05 AM
Unknown Object (File)
Sat, Nov 9, 2:45 AM
Unknown Object (File)
Fri, Nov 8, 5:12 PM
Unknown Object (File)
Oct 23 2024, 7:24 PM
Unknown Object (File)
Oct 23 2024, 7:24 PM
View All 60 Files
Subscribers
ashoat

Details

Reviewers
marcin
varun
tomek
Commits
rCOMM912919f516fc: [crypto] unify key types and introduce type for Inbound Keys
Summary
  1. Move some types from CommCoreModuleSchema.js -> crypto-types.js
  2. Add validator for SignedPrekeys
  3. UserDevicesOlmInboundKeys type and validator
  4. Group types in identity-service-types.js
Test Plan

FLow

Diff Detail

Repository
rCOMM Comm
Branch
olm-web-4
Lint
No Lint Coverage
Unit
No Test Coverage

Event Timeline

kamil created this revision.Feb 19 2024, 7:35 AM
kamil held this revision as a draft.
Herald added a subscriber: ashoat. · View Herald TranscriptFeb 19 2024, 7:35 AM
kamil added a child revision: D11107: [web] implementing getting inbound user keys in `IdentityServiceClient`.Feb 19 2024, 7:46 AM
Harbormaster completed remote builds in B26964: Diff 37323.Feb 19 2024, 7:50 AM
kamil published this revision for review.Feb 19 2024, 9:35 AM
tomek accepted this revision.Feb 21 2024, 1:48 AM
tomek added inline comments.
lib/types/crypto-types.js
25–28

It might appear more convenient to have two fields, one for content and one for notif, each being an object with prekey and prekeySignature

lib/types/identity-service-types.js
87–88

Can these two be null at the same time? If not, then can we reflect that in the type?

This revision is now accepted and ready to land.Feb 21 2024, 1:48 AM
kamil updated this revision to Diff 37445.Feb 22 2024, 7:55 AM

add validator

kamil added inline comments.Feb 22 2024, 7:58 AM
lib/types/crypto-types.js
25–28

I am just moving this type - it will require changing C++ code which returns prekeys

lib/types/identity-service-types.js
87–88

This is based on InboundKeyInfoResponse - but there is some ongoing work to improve it (https://phab.comm.dev/D11108#inline-67556)

Harbormaster failed remote builds in B27067: Diff 37445!Feb 22 2024, 8:03 AM
This revision was landed with ongoing or failed builds.Feb 23 2024, 1:32 AM
Closed by commit rCOMM912919f516fc: [crypto] unify key types and introduce type for Inbound Keys (authored by kamil). · Explain Why
This revision was automatically updated to reflect the committed changes.
kamil added a commit: rCOMM912919f516fc: [crypto] unify key types and introduce type for Inbound Keys.

Revision Contents
Changeset List

PathSize
lib/
types/
20 lines
50 lines
native/
schema/
14 lines

Diff 37323

View Options

lib/types/crypto-types.js

Loading...
View Options

lib/types/identity-service-types.js

Loading...
View Options

native/schema/CommCoreModuleSchema.js

Loading...