Page MenuHomePhabricator
Differential D11153

[sqlite] implement c++ code to get communities
ClosedPublic
Actions

Authored by ginsu on Feb 23 2024, 12:29 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Mar 4, 6:27 PM
Unknown Object (File)
Feb 21 2025, 8:27 PM
Unknown Object (File)
Feb 21 2025, 8:27 PM
Unknown Object (File)
Feb 21 2025, 8:27 PM
Unknown Object (File)
Feb 21 2025, 8:27 PM
Unknown Object (File)
Feb 21 2025, 8:27 PM
Unknown Object (File)
Feb 21 2025, 8:27 PM
Unknown Object (File)
Feb 21 2025, 8:27 PM
View All 96 Files
Subscribers
ashoat
tomek

Details

Reviewers
atul
inka
kamil
Commits
rCOMMb1f35f4bd8e6: [sqlite] implement c++ code to get communities
Summary

Introduced all the necessary code for native ops for getting communities from the community store

Linear task: https://linear.app/comm/issue/ENG-6533/implement-c-code-to-get-communities

Depends on D11152

Test Plan

In a subsequent diff I will introduce logic to read communities from sqlite on app start and I was able to see that using the c++ code introduced in this diff I was able to get the communities into my redux store

Screenshot 2024-02-23 at 3.25.08 AM.png (1×3 px, 1 MB)

Screenshot 2024-02-23 at 3.25.00 AM.png (1×1 px, 648 KB)

Also called the following code:

const TEST_COMMUNITY_1: CommunityInfo = {
  enabledApps: {
    calendar: false,
    wiki: false,
    tasks: true,
    files: true,
  },
};

const TEST_COMMUNITY_2: CommunityInfo = {
  enabledApps: {
    calendar: true,
    wiki: false,
    tasks: false,
    files: false,
  },
};

let data = await commCoreModule.getClientDBStore();
console.log(data.communities);

await commCoreModule.processCommunityStoreOperations([
  {
    type: 'replace_community',
    payload: {
      id: '1',
      communityInfo: TEST_COMMUNITY_1,
    },
  },
  {
    type: 'replace_community',
    payload: {
      id: '2',
      communityInfo: TEST_COMMUNITY_2,
    },
  },
]);

data = await commCoreModule.getClientDBStore();
console.log(data.communities);

const community2Updated: CommunityInfo = {
  enabledApps: {
    calendar: true,
    wiki: true,
    tasks: true,
    files: true,
  },
};

await commCoreModule.processCommunityStoreOperations([
  {
    type: 'replace_community',
    payload: {
      id: '2',
      communityInfo: community2Updated,
    },
  },
]);

data = await commCoreModule.getClientDBStore();
console.log(data.communities);

await commCoreModule.processCommunityStoreOperations([
  {
    type: 'remove_communities',
    payload: {
      ids: ['1'],
    },
  },
]);

data = await commCoreModule.getClientDBStore();
console.log(data.communities);

await commCoreModule.processCommunityStoreOperations([
  {
    type: 'remove_all_communities',
  },
]);

data = await commCoreModule.getClientDBStore();
console.log(data.communities);

Diff Detail

Repository
rCOMM Comm
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ginsu created this revision.Feb 23 2024, 12:29 AM
Herald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 23 2024, 12:29 AM
ginsu updated this revision to Diff 37481.Feb 23 2024, 12:34 AM

update

ginsu edited the summary of this revision. (Show Details)Feb 23 2024, 12:37 AM
ginsu edited the test plan for this revision. (Show Details)
ginsu added reviewers: atul, inka, kamil.
ginsu added a parent revision: D11152: [sqlite] implement C++ community store ops.
ginsu attached a referenced file: F1214249: Screenshot 2024-02-23 at 3.25.00 AM.png. (Show Details)
ginsu attached a referenced file: F1214250: Screenshot 2024-02-23 at 3.25.08 AM.png. (Show Details)
Harbormaster returned this revision to the author for changes because remote builds failed.Feb 23 2024, 12:42 AM
Harbormaster failed remote builds in B27089: Diff 37481!
ginsu requested review of this revision.Feb 23 2024, 12:43 AM

will make sure ci passes before landing

Harbormaster completed remote builds in B27087: Diff 37479.Feb 23 2024, 12:44 AM
kamil mentioned this in D11152: [sqlite] implement C++ community store ops.Feb 23 2024, 6:27 AM
kamil accepted this revision.Feb 23 2024, 6:30 AM

Same as D11152 - it will be nice to make the testing process more transparent

This revision is now accepted and ready to land.Feb 23 2024, 6:30 AM
ginsu added a child revision: D11164: [sqlite] implement processing community store ops on worker.Feb 25 2024, 11:50 PM
Harbormaster completed remote builds in B27089: Diff 37481.Feb 26 2024, 1:50 PM
ginsu edited the test plan for this revision. (Show Details)Feb 27 2024, 7:35 PM

it will be nice to make the testing process more transparent

updated test plan

ginsu updated this revision to Diff 37669.Feb 27 2024, 7:37 PM

rebase before landing

ginsu updated this revision to Diff 37670.Feb 27 2024, 7:38 PM

rebase before landing

Harbormaster failed remote builds in B27217: Diff 37670!Feb 27 2024, 7:43 PM
Harbormaster completed remote builds in B27216: Diff 37669.Feb 27 2024, 7:53 PM
This revision was landed with ongoing or failed builds.Feb 27 2024, 8:02 PM
Closed by commit rCOMMb1f35f4bd8e6: [sqlite] implement c++ code to get communities (authored by ginsu). · Explain Why
This revision was automatically updated to reflect the committed changes.
ginsu added a commit: rCOMMb1f35f4bd8e6: [sqlite] implement c++ code to get communities.

Revision Contents
Changeset List

PathSize
lib/
types/
2 lines
native/
cpp/
CommonCpp/
NativeModules/
16 lines
PersistentStorageUtilities/
DataStores/
10 lines
web/
database/
worker/
1 line

Diff 37676

View Options

lib/types/store-ops-types.js

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import _mapValues from 'lodash/fp/mapValues.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { useENSNames } from '../hooks/ens-cache.js'; import { useENSNames } from '../hooks/ens-cache.js';
import SearchIndex from '../shared/search-index.js'; import SearchIndex from '../shared/search-index.js';
import { roleIsAdminRole } from '../shared/thread-utils.js'; import {
roleIsAdminRole,
useCommunityRootMembersToRole,
} from '../shared/thread-utils.js';
import type { Platform } from '../types/device-types.js'; import type { Platform } from '../types/device-types.js';
import { import {
type CalendarQuery, type CalendarQuery,
defaultCalendarQuery, defaultCalendarQuery,
} from '../types/entry-types.js'; } from '../types/entry-types.js';
import type { CalendarFilter } from '../types/filter-types.js'; import type { CalendarFilter } from '../types/filter-types.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseNavInfo } from '../types/nav-types.js'; import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function timeUntilCalendarRangeExpiration( function timeUntilCalendarRangeExpiration(
lastUserInteractionCalendar: number, lastUserInteractionCalendar: number,
): ?number { ): ?number {
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
function useThreadSearchIndex( function useThreadSearchIndex(
threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>, threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>,
): SearchIndex { ): SearchIndex {
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const viewerID = useSelector( const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const communityRootMembersToRole = React.useMemo(() => { const communityRootMembersToRole = useCommunityRootMembersToRole(threadInfos);
const communityThreadInfos = threadInfos.filter(threadInfo =>
threadTypeIsCommunityRoot(threadInfo.type),
);
const communityRoots = _keyBy('id')(communityThreadInfos);
return _mapValues((threadInfo: ThreadInfo | RawThreadInfo) => {
const keyedMembers = _keyBy('id')(threadInfo.members);
const keyedMembersToRole = _mapValues(
(member: MemberInfo | RelativeMemberInfo) => {
return member.role ? threadInfo.roles[member.role] : null;
},
)(keyedMembers);
return keyedMembersToRole;
})(communityRoots);
}, [threadInfos]);
const nonViewerMembers = React.useMemo(() => { const nonViewerMembers = React.useMemo(() => {
const allMembersOfAllThreads = new Map<string, UserInfo>(); const allMembersOfAllThreads = new Map<string, UserInfo>();
for (const threadInfo of threadInfos) { for (const threadInfo of threadInfos) {
for (const member of threadInfo.members) { for (const member of threadInfo.members) {
const communityRole = const communityRole =
communityRootMembersToRole[threadInfo.community]?.[member.id]; communityRootMembersToRole[threadInfo.community]?.[member.id];
const isParentAdmin = roleIsAdminRole(communityRole); const isParentAdmin = roleIsAdminRole(communityRole);
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import _mapValues from 'lodash/fp/mapValues.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { useENSNames } from '../hooks/ens-cache.js'; import { useENSNames } from '../hooks/ens-cache.js';
import SearchIndex from '../shared/search-index.js'; import SearchIndex from '../shared/search-index.js';
import { roleIsAdminRole } from '../shared/thread-utils.js'; import {
roleIsAdminRole,
useCommunityRootMembersToRole,
} from '../shared/thread-utils.js';
import type { Platform } from '../types/device-types.js'; import type { Platform } from '../types/device-types.js';
import { import {
type CalendarQuery, type CalendarQuery,
defaultCalendarQuery, defaultCalendarQuery,
} from '../types/entry-types.js'; } from '../types/entry-types.js';
import type { CalendarFilter } from '../types/filter-types.js'; import type { CalendarFilter } from '../types/filter-types.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseNavInfo } from '../types/nav-types.js'; import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function timeUntilCalendarRangeExpiration( function timeUntilCalendarRangeExpiration(
lastUserInteractionCalendar: number, lastUserInteractionCalendar: number,
): ?number { ): ?number {
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
function useThreadSearchIndex( function useThreadSearchIndex(
threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>, threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>,
): SearchIndex { ): SearchIndex {
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const viewerID = useSelector( const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const communityRootMembersToRole = React.useMemo(() => { const communityRootMembersToRole = useCommunityRootMembersToRole(threadInfos);
const communityThreadInfos = threadInfos.filter(threadInfo =>
threadTypeIsCommunityRoot(threadInfo.type),
);
const communityRoots = _keyBy('id')(communityThreadInfos);
return _mapValues((threadInfo: ThreadInfo | RawThreadInfo) => {
const keyedMembers = _keyBy('id')(threadInfo.members);
const keyedMembersToRole = _mapValues(
(member: MemberInfo | RelativeMemberInfo) => {
return member.role ? threadInfo.roles[member.role] : null;
},
)(keyedMembers);
return keyedMembersToRole;
})(communityRoots);
}, [threadInfos]);
const nonViewerMembers = React.useMemo(() => { const nonViewerMembers = React.useMemo(() => {
const allMembersOfAllThreads = new Map<string, UserInfo>(); const allMembersOfAllThreads = new Map<string, UserInfo>();
for (const threadInfo of threadInfos) { for (const threadInfo of threadInfos) {
for (const member of threadInfo.members) { for (const member of threadInfo.members) {
const communityRole = const communityRole =
communityRootMembersToRole[threadInfo.community]?.[member.id]; communityRootMembersToRole[threadInfo.community]?.[member.id];
const isParentAdmin = roleIsAdminRole(communityRole); const isParentAdmin = roleIsAdminRole(communityRole);
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines
View Options

native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/CommunityStore.cpp

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import _mapValues from 'lodash/fp/mapValues.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { useENSNames } from '../hooks/ens-cache.js'; import { useENSNames } from '../hooks/ens-cache.js';
import SearchIndex from '../shared/search-index.js'; import SearchIndex from '../shared/search-index.js';
import { roleIsAdminRole } from '../shared/thread-utils.js'; import {
roleIsAdminRole,
useCommunityRootMembersToRole,
} from '../shared/thread-utils.js';
import type { Platform } from '../types/device-types.js'; import type { Platform } from '../types/device-types.js';
import { import {
type CalendarQuery, type CalendarQuery,
defaultCalendarQuery, defaultCalendarQuery,
} from '../types/entry-types.js'; } from '../types/entry-types.js';
import type { CalendarFilter } from '../types/filter-types.js'; import type { CalendarFilter } from '../types/filter-types.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseNavInfo } from '../types/nav-types.js'; import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function timeUntilCalendarRangeExpiration( function timeUntilCalendarRangeExpiration(
lastUserInteractionCalendar: number, lastUserInteractionCalendar: number,
): ?number { ): ?number {
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
function useThreadSearchIndex( function useThreadSearchIndex(
threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>, threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>,
): SearchIndex { ): SearchIndex {
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const viewerID = useSelector( const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const communityRootMembersToRole = React.useMemo(() => { const communityRootMembersToRole = useCommunityRootMembersToRole(threadInfos);
const communityThreadInfos = threadInfos.filter(threadInfo =>
threadTypeIsCommunityRoot(threadInfo.type),
);
const communityRoots = _keyBy('id')(communityThreadInfos);
return _mapValues((threadInfo: ThreadInfo | RawThreadInfo) => {
const keyedMembers = _keyBy('id')(threadInfo.members);
const keyedMembersToRole = _mapValues(
(member: MemberInfo | RelativeMemberInfo) => {
return member.role ? threadInfo.roles[member.role] : null;
},
)(keyedMembers);
return keyedMembersToRole;
})(communityRoots);
}, [threadInfos]);
const nonViewerMembers = React.useMemo(() => { const nonViewerMembers = React.useMemo(() => {
const allMembersOfAllThreads = new Map<string, UserInfo>(); const allMembersOfAllThreads = new Map<string, UserInfo>();
for (const threadInfo of threadInfos) { for (const threadInfo of threadInfos) {
for (const member of threadInfo.members) { for (const member of threadInfo.members) {
const communityRole = const communityRole =
communityRootMembersToRole[threadInfo.community]?.[member.id]; communityRootMembersToRole[threadInfo.community]?.[member.id];
const isParentAdmin = roleIsAdminRole(communityRole); const isParentAdmin = roleIsAdminRole(communityRole);
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines
View Options

web/database/worker/process-operations.js

// @flow // @flow
import _keyBy from 'lodash/fp/keyBy.js';
import _mapValues from 'lodash/fp/mapValues.js';
import * as React from 'react'; import * as React from 'react';
import { createSelector } from 'reselect'; import { createSelector } from 'reselect';
import { useENSNames } from '../hooks/ens-cache.js'; import { useENSNames } from '../hooks/ens-cache.js';
import SearchIndex from '../shared/search-index.js'; import SearchIndex from '../shared/search-index.js';
import { roleIsAdminRole } from '../shared/thread-utils.js'; import {
roleIsAdminRole,
useCommunityRootMembersToRole,
} from '../shared/thread-utils.js';
import type { Platform } from '../types/device-types.js'; import type { Platform } from '../types/device-types.js';
import { import {
type CalendarQuery, type CalendarQuery,
defaultCalendarQuery, defaultCalendarQuery,
} from '../types/entry-types.js'; } from '../types/entry-types.js';
import type { CalendarFilter } from '../types/filter-types.js'; import type { CalendarFilter } from '../types/filter-types.js';
import type { import type {
ThreadInfo, ThreadInfo,
RelativeMemberInfo, RelativeMemberInfo,
RawThreadInfo, RawThreadInfo,
MemberInfo,
} from '../types/minimally-encoded-thread-permissions-types.js'; } from '../types/minimally-encoded-thread-permissions-types.js';
import type { BaseNavInfo } from '../types/nav-types.js'; import type { BaseNavInfo } from '../types/nav-types.js';
import type { BaseAppState } from '../types/redux-types.js'; import type { BaseAppState } from '../types/redux-types.js';
import { threadTypeIsCommunityRoot } from '../types/thread-types-enum.js';
import type { UserInfo } from '../types/user-types.js'; import type { UserInfo } from '../types/user-types.js';
import { getConfig } from '../utils/config.js'; import { getConfig } from '../utils/config.js';
import { values } from '../utils/objects.js'; import { values } from '../utils/objects.js';
import { useSelector } from '../utils/redux-utils.js'; import { useSelector } from '../utils/redux-utils.js';
function timeUntilCalendarRangeExpiration( function timeUntilCalendarRangeExpiration(
lastUserInteractionCalendar: number, lastUserInteractionCalendar: number,
): ?number { ): ?number {
▲ Show 20 Lines • Show All 92 Lines • ▼ Show 20 Lines
function useThreadSearchIndex( function useThreadSearchIndex(
threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>, threadInfos: $ReadOnlyArray<RawThreadInfo | ThreadInfo>,
): SearchIndex { ): SearchIndex {
const userInfos = useSelector(state => state.userStore.userInfos); const userInfos = useSelector(state => state.userStore.userInfos);
const viewerID = useSelector( const viewerID = useSelector(
state => state.currentUserInfo && state.currentUserInfo.id, state => state.currentUserInfo && state.currentUserInfo.id,
); );
const communityRootMembersToRole = React.useMemo(() => { const communityRootMembersToRole = useCommunityRootMembersToRole(threadInfos);
const communityThreadInfos = threadInfos.filter(threadInfo =>
threadTypeIsCommunityRoot(threadInfo.type),
);
const communityRoots = _keyBy('id')(communityThreadInfos);
return _mapValues((threadInfo: ThreadInfo | RawThreadInfo) => {
const keyedMembers = _keyBy('id')(threadInfo.members);
const keyedMembersToRole = _mapValues(
(member: MemberInfo | RelativeMemberInfo) => {
return member.role ? threadInfo.roles[member.role] : null;
},
)(keyedMembers);
return keyedMembersToRole;
})(communityRoots);
}, [threadInfos]);
const nonViewerMembers = React.useMemo(() => { const nonViewerMembers = React.useMemo(() => {
const allMembersOfAllThreads = new Map<string, UserInfo>(); const allMembersOfAllThreads = new Map<string, UserInfo>();
for (const threadInfo of threadInfos) { for (const threadInfo of threadInfos) {
for (const member of threadInfo.members) { for (const member of threadInfo.members) {
const communityRole = const communityRole =
communityRootMembersToRole[threadInfo.community]?.[member.id]; communityRootMembersToRole[threadInfo.community]?.[member.id];
const isParentAdmin = roleIsAdminRole(communityRole); const isParentAdmin = roleIsAdminRole(communityRole);
▲ Show 20 Lines • Show All 84 Lines • Show Last 20 Lines