Introduced all the necessary code for native ops for modifying the community store
Linear task: https://linear.app/comm/issue/ENG-6532/implement-c-community-store-ops
Depends on D11151
Differential D11152
[sqlite] implement C++ community store ops Authored by ginsu on Feb 23 2024, 8:03 AM.
Details
Introduced all the necessary code for native ops for modifying the community store Linear task: https://linear.app/comm/issue/ENG-6532/implement-c-community-store-ops Depends on D11151 Ran the following code: const TEST_COMMUNITY_1: CommunityInfo = {
enabledApps: {
calendar: false,
wiki: false,
tasks: true,
files: true,
},
};
const TEST_COMMUNITY_2: CommunityInfo = {
enabledApps: {
calendar: true,
wiki: false,
tasks: false,
files: false,
},
};
await commCoreModule.processCommunityStoreOperations([
{
type: 'replace_community',
payload: {
id: '1',
communityInfo: TEST_COMMUNITY_1,
},
},
{
type: 'replace_community',
payload: {
id: '2',
communityInfo: TEST_COMMUNITY_2,
},
},
]);
const community2Updated: CommunityInfo = {
enabledApps: {
calendar: true,
wiki: true,
tasks: true,
files: true,
},
};
await commCoreModule.processCommunityStoreOperations([
{
type: 'replace_community',
payload: {
id: '2',
communityInfo: community2Updated,
},
},
]);
await commCoreModule.processCommunityStoreOperations([
{
type: 'remove_communities',
payload: {
ids: ['1'],
},
},
]);
await commCoreModule.processCommunityStoreOperations([
{
type: 'remove_all_communities',
},
]);
Diff Detail
Event TimelineComment Actions Looks correct! One question about testing - processCommunityStoreOperations is not called anywhere so I don't think it caused any changes in SQLite:
Comment Actions Actually, looking at D11153 I see it was tested so unblocking but it would be great if you could respond and update the test plan Comment Actions
Test plan has been updated |