Introduced all the necessary code for native ops for modifying the community store
Linear task: https://linear.app/comm/issue/ENG-6532/implement-c-community-store-ops
Depends on D11151
Paths
| Differential D11152 Authored by ginsu on Feb 23 2024, 12:03 AM.
Details
Summary Introduced all the necessary code for native ops for modifying the community store Linear task: https://linear.app/comm/issue/ENG-6532/implement-c-community-store-ops Depends on D11151 Test Plan Ran the following code: const TEST_COMMUNITY_1: CommunityInfo = { enabledApps: { calendar: false, wiki: false, tasks: true, files: true, }, }; const TEST_COMMUNITY_2: CommunityInfo = { enabledApps: { calendar: true, wiki: false, tasks: false, files: false, }, }; await commCoreModule.processCommunityStoreOperations([ { type: 'replace_community', payload: { id: '1', communityInfo: TEST_COMMUNITY_1, }, }, { type: 'replace_community', payload: { id: '2', communityInfo: TEST_COMMUNITY_2, }, }, ]); const community2Updated: CommunityInfo = { enabledApps: { calendar: true, wiki: true, tasks: true, files: true, }, }; await commCoreModule.processCommunityStoreOperations([ { type: 'replace_community', payload: { id: '2', communityInfo: community2Updated, }, }, ]); await commCoreModule.processCommunityStoreOperations([ { type: 'remove_communities', payload: { ids: ['1'], }, }, ]); await commCoreModule.processCommunityStoreOperations([ { type: 'remove_all_communities', }, ]);
Diff Detail
Event TimelineHerald added subscribers: tomek, ashoat. · View Herald TranscriptFeb 23 2024, 12:03 AM2024-02-23 00:03:56 (UTC-8) ginsu edited the summary of this revision. (Show Details)Feb 23 2024, 12:10 AM2024-02-23 00:10:56 (UTC-8) Harbormaster completed remote builds in B27085: Diff 37477.Feb 23 2024, 12:18 AM2024-02-23 00:18:48 (UTC-8) ginsu edited the summary of this revision. (Show Details)Feb 23 2024, 12:27 AM2024-02-23 00:27:09 (UTC-8) Harbormaster completed remote builds in B27088: Diff 37480.Feb 23 2024, 12:48 AM2024-02-23 00:48:49 (UTC-8) Comment Actions Looks correct! One question about testing - processCommunityStoreOperations is not called anywhere so I don't think it caused any changes in SQLite:
This revision now requires changes to proceed.Feb 23 2024, 6:25 AM2024-02-23 06:25:04 (UTC-8) Comment Actions Actually, looking at D11153 I see it was tested so unblocking but it would be great if you could respond and update the test plan This revision is now accepted and ready to land.Feb 23 2024, 6:27 AM2024-02-23 06:27:07 (UTC-8) ginsu edited the test plan for this revision. (Show Details)Feb 27 2024, 7:30 PM2024-02-27 19:30:08 (UTC-8) Comment Actions
Test plan has been updated Harbormaster completed remote builds in B27215: Diff 37668.Feb 27 2024, 7:52 PM2024-02-27 19:52:39 (UTC-8) Closed by commit rCOMM571ae32fcd45: [sqlite] implement C++ community store ops (authored by ginsu). · Explain WhyFeb 27 2024, 8:02 PM2024-02-27 20:02:27 (UTC-8) This revision was automatically updated to reflect the committed changes.
Revision Contents
Diff 37675 native/cpp/CommonCpp/NativeModules/CMakeLists.txt
native/cpp/CommonCpp/NativeModules/CommCoreModule.h
native/cpp/CommonCpp/NativeModules/CommCoreModule.cpp
native/cpp/CommonCpp/NativeModules/CommunityStoreOperations.h
native/cpp/CommonCpp/NativeModules/PersistentStorageUtilities/DataStores/CommunityStore.h
|